Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize startup times for libraries with lots of stacks #1792

Open
adamwulf opened this issue Jul 5, 2017 · 1 comment
Open

Optimize startup times for libraries with lots of stacks #1792

adamwulf opened this issue Jul 5, 2017 · 1 comment
Labels
enhancement

Comments

@adamwulf
Copy link
Owner

adamwulf commented Jul 5, 2017

currently all pages for all stacks are loaded at launch. Instead, only load all pages for the currently visible stack, and top 20 pages for all other stacks. then load the rest of a stack on demand when that stack is opened.
@adamwulf adamwulf added this to the v3.1.3 milestone Jul 5, 2017
@adamwulf
Copy link
Owner Author

adamwulf commented Jul 5, 2017

I think I can only ever load 20 pages in loadStacksFromDiskIntoListViewIgnoringMeta:.

Then, in organizePagesIntoListAnimated: and immediatelyTransitionToPageViewAnimated: I can check to see if we're 100% loaded, and load the rest if not.

Need to double check that saveStacksToDisk is ignored if the stack isn't fully loaded.

@adamwulf adamwulf removed this from the v3.1.3 milestone Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamwulf