Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting travel (like freeze_time) as a pytest marker #142

Open
MRigal opened this issue May 26, 2021 · 4 comments
Open

Consider supporting travel (like freeze_time) as a pytest marker #142

MRigal opened this issue May 26, 2021 · 4 comments

Comments

@MRigal
Copy link

MRigal commented May 26, 2021

Hi @adamchainz !

Thanks for this great library!

If it does not come with a too high performance impact, similar to https://github.com/ktosiek/pytest-freezegun/pull/14/files consider supporting travel as a marker?

Best,
Matthieu

@adamchainz
Copy link
Owner

Yes sure, would you be able to put together a first PR? I don't think there would be any performance concern.

@MRigal
Copy link
Author

MRigal commented May 26, 2021

Yes I can give it a try. However, I've noticed that you raise a TypeError("Can only decorate unittest.TestCase subclasses.") which might be problematic since it would be a test decorator... Or am I missing something?

@adamchainz
Copy link
Owner

Yes, I think the mark should interact with the existing pytest fixture and then you won't have any porblems.

@MRigal
Copy link
Author

MRigal commented Jun 2, 2021

The library shift got unprioritized for now. Thus I could only try to make it on my free time, which makes it less likely to happen soon, just to let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants