diff --git a/app/__init__.py b/app/__init__.py index 2764c4cc8..fa70fc4bc 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -30,5 +30,9 @@ def create_app(test_config=None): migrate.init_app(app, db) # Register Blueprints here + from .routes.task_routes import task_bp + app.register_blueprint(task_bp) + from .routes.goal_routes import goal_bp + app.register_blueprint(goal_bp) return app diff --git a/app/models/goal.py b/app/models/goal.py index b0ed11dd8..503a45074 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -1,5 +1,37 @@ from app import db - +from flask import jsonify, abort, make_response class Goal(db.Model): + goal_id = db.Column(db.Integer, primary_key=True) + title = db.Column(db.String, nullable = False) + tasks = db.relationship("Task", back_populates="goal", lazy=True) + + def to_json(self): + + return { + "id": self.goal_id, + "title": self.title + } + + @classmethod + def validate(cls, goal_id): + try: + goal_id = int(goal_id) + except: + abort(make_response(jsonify(f"{goal_id} is not a valid goal id."),400)) + goal = cls.query.get(goal_id) + if goal: + return goal + abort(make_response(jsonify(f"Goal with id of {goal_id} was not found"),404)) + + @classmethod + def create(cls,request_body): + new_goal = cls( + title = request_body['title'] + + ) + return new_goal + + def update(self,request_body): + self.title = request_body["title"] diff --git a/app/models/task.py b/app/models/task.py index c91ab281f..f0a1ff8a0 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,56 @@ from app import db - +from flask import jsonify, abort, make_response class Task(db.Model): + task_id = db.Column(db.Integer, primary_key=True) + title = db.Column(db.String, nullable = False) + description = db.Column(db.String) + completed_at = db.Column(db.DateTime) + goal_id = db.Column (db.Integer, db.ForeignKey('goal.goal_id'), nullable=True) + goal = db.relationship("Goal", back_populates="tasks") + + def to_json(self): + if not self.completed_at: + is_complete = False + else: + is_complete = True + + task_dict = { + "id": self.task_id, + "title": self.title, + "description": self.description, + "is_complete": is_complete + } + + if self.goal_id: + task_dict["goal_id"] = self.goal_id + + return task_dict + + + + @classmethod + def validate(cls, task_id): + try: + task_id = int(task_id) + except: + abort(make_response(jsonify(f"{task_id} is not a valid task id."),400)) + task = cls.query.get(task_id) + if task: + return task + abort(make_response(jsonify(f"Task with id of {task_id} was not found"),404)) + + @classmethod + def create(cls,request_body): + new_task = cls( + title = request_body['title'], + description = request_body['description'], + completed_at = request_body.get('completed_at', None) + + ) + return new_task + + def update(self,request_body): + self.title = request_body["title"] + self.description = request_body["description"] diff --git a/app/routes.py b/app/routes.py deleted file mode 100644 index 3aae38d49..000000000 --- a/app/routes.py +++ /dev/null @@ -1 +0,0 @@ -from flask import Blueprint \ No newline at end of file diff --git a/app/routes/goal_routes.py b/app/routes/goal_routes.py new file mode 100644 index 000000000..9e73c04e1 --- /dev/null +++ b/app/routes/goal_routes.py @@ -0,0 +1,113 @@ +from datetime import date +from urllib import response +from flask import Blueprint, jsonify, make_response, abort, request +from app.models.goal import Goal +from app.models.task import Task +from app import db + +goal_bp = Blueprint("goals", __name__, url_prefix="/goals") + +@goal_bp.route("", methods = ["GET"]) +def get_all_goal(): + goal_response_body = [] + + if request.args.get("sort") == "asc": + goals = Goal.query.order_by(Goal.title.asc()) + elif request.args.get("sort") == "desc": + goals = Goal.query.order_by(Goal.title.desc()) + else: + goals = Goal.query.all() + + for goal in goals: + goal_response_body.append(goal.to_json()) + + return jsonify(goal_response_body), 200 + +@goal_bp.route("", methods = ["POST"]) +def create_goal(): + request_body = request.get_json() + print(request_body) + + try: + new_goal = Goal.create(request_body) + except KeyError: + return {"details": "Invalid data"}, 400 + + db.session.add(new_goal) + db.session.commit() + + response_body = {} + response_body["goal"] = new_goal.to_json() + return jsonify(response_body), 201 + +@goal_bp.route("/", methods = ["GET"]) +def get_one_goal(id): + one_goal = Goal.validate(id) + response_body = {} + response_body["goal"] = one_goal.to_json() + + return jsonify(response_body), 200 + +@goal_bp.route("/", methods = ["PUT"]) +def update_goal(id): + one_goal = Goal.validate(id) + request_body = request.get_json() + + one_goal.update(request_body) + + db.session.commit() + response_body = {} + response_body["goal"] = one_goal.to_json() + + return jsonify(response_body), 200 + + +@goal_bp.route("/", methods = ["DELETE"]) +def delete_goal(id): + one_goal = Goal.validate(id) + db.session.delete(one_goal) + db.session.commit() + + return jsonify({"details": f'Goal {one_goal.goal_id} "{one_goal.title}" successfully deleted'}) + +@goal_bp.route("//tasks", methods = ["POST"]) +def list_of_task_to_goal(id): + valid_goal = Goal.validate(id) + request_body = request.get_json() + + for task_id in request_body["task_ids"]: + Task.validate(task_id) + task = Task.query.get(task_id) + task.goal_id = valid_goal.goal_id + + db.session.commit() + task_list = [] + + for task in valid_goal.tasks: + task_list.append(task.task_id) + + response_body = {} + response_body = { + "id": valid_goal.goal_id, + "task_ids": task_list} + + return jsonify(response_body), 200 + +@goal_bp.route("//tasks", methods = ["GET"]) +def get_task_one_goal(id): + valid_goal = Goal.validate(id) + task_list = [] + + for task in valid_goal.tasks: + task_list.append(task.to_json()) + + response_body = {} + response_body = { + "id": valid_goal.goal_id, + "title": valid_goal.title, + "tasks": task_list} + + return jsonify(response_body), 200 + + + diff --git a/app/routes/task_routes.py b/app/routes/task_routes.py new file mode 100644 index 000000000..1f7f9d11d --- /dev/null +++ b/app/routes/task_routes.py @@ -0,0 +1,104 @@ +from datetime import date +from urllib import response +from flask import Blueprint, jsonify, make_response, abort, request +from app.models.task import Task +from app import db + + +task_bp = Blueprint("tasks", __name__, url_prefix="/tasks") + + +@task_bp.route("", methods=["GET"]) +def get_all_tasks(): + task_response_body = [] + # tasks = Task.query.all() + + if request.args.get("sort") == "asc": + tasks = Task.query.order_by(Task.title.asc()) + elif request.args.get("sort") == "desc": + tasks = Task.query.order_by(Task.title.desc()) + else: + tasks = Task.query.all() + + for task in tasks: + task_response_body.append(task.to_json()) + + return jsonify(task_response_body), 200 + +@task_bp.route("", methods=["POST"]) +def create_task(): + request_body = request.get_json() + print(request_body) + + try: + new_task = Task.create(request_body) + except KeyError: + return {"details": "Invalid data"}, 400 + + db.session.add(new_task) + db.session.commit() + + response_body = {} + response_body["task"] = new_task.to_json() + return jsonify(response_body), 201 + + + +@task_bp.route("/", methods = ["GET"]) +def get_one_tasks(id): + one_task = Task.validate(id) + response_body = {} + response_body["task"] = one_task.to_json() + + return jsonify(response_body), 200 + +@task_bp.route("/", methods = ["PUT"]) +def update_task(id): + one_task = Task.validate(id) + request_body = request.get_json() + + one_task.update(request_body) + + db.session.commit() + response_body = {} + response_body["task"] = one_task.to_json() + + return jsonify(response_body), 200 + +@task_bp.route("/", methods = ["DELETE"]) +def delete_task(id): + one_task = Task.validate(id) + db.session.delete(one_task) + db.session.commit() + + return jsonify({"details": f'Task {one_task.task_id} "{one_task.title}" successfully deleted'}) + + +@task_bp.route("//mark_complete", methods = ["PATCH"]) +def mark_complete(id): + one_task = Task.validate(id) + + one_task.completed_at = date.today() + + db.session.commit() + response_body = {} + response_body["task"] = one_task.to_json() + + return jsonify(response_body), 200 + +@task_bp.route("//mark_incomplete", methods = ["PATCH"]) +def mark_incomplete(id): + one_task = Task.validate(id) + one_task.completed_at = None + + db.session.commit() + response_body = {} + response_body["task"] = one_task.to_json() + + return jsonify(response_body), 200 + + + + + + diff --git a/code b/code new file mode 100644 index 000000000..e69de29bb diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/48907f71ca3c_.py b/migrations/versions/48907f71ca3c_.py new file mode 100644 index 000000000..598ffde45 --- /dev/null +++ b/migrations/versions/48907f71ca3c_.py @@ -0,0 +1,32 @@ +"""empty message + +Revision ID: 48907f71ca3c +Revises: 9b90ac0681f9 +Create Date: 2022-05-26 18:03:18.075104 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '48907f71ca3c' +down_revision = '9b90ac0681f9' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('goal_id', sa.Integer(), nullable=False), + sa.Column('title', sa.String(), nullable=False), + sa.PrimaryKeyConstraint('goal_id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/migrations/versions/9b90ac0681f9_create_a_task.py b/migrations/versions/9b90ac0681f9_create_a_task.py new file mode 100644 index 000000000..a219e4239 --- /dev/null +++ b/migrations/versions/9b90ac0681f9_create_a_task.py @@ -0,0 +1,34 @@ +"""Create a Task + +Revision ID: 9b90ac0681f9 +Revises: +Create Date: 2022-05-26 10:12:25.765311 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '9b90ac0681f9' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('task', + sa.Column('task_id', sa.Integer(), nullable=False), + sa.Column('title', sa.String(), nullable=False), + sa.Column('description', sa.String(), nullable=True), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.PrimaryKeyConstraint('task_id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + # ### end Alembic commands ### diff --git a/migrations/versions/b0394dbbf472_updating_relationships.py b/migrations/versions/b0394dbbf472_updating_relationships.py new file mode 100644 index 000000000..e23b8c9d8 --- /dev/null +++ b/migrations/versions/b0394dbbf472_updating_relationships.py @@ -0,0 +1,30 @@ +"""Updating relationships + +Revision ID: b0394dbbf472 +Revises: 48907f71ca3c +Create Date: 2022-05-30 11:47:33.246990 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'b0394dbbf472' +down_revision = '48907f71ca3c' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('task', sa.Column('goal_id', sa.Integer(), nullable=True)) + op.create_foreign_key(None, 'task', 'goal', ['goal_id'], ['goal_id']) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_constraint(None, 'task', type_='foreignkey') + op.drop_column('task', 'goal_id') + # ### end Alembic commands ### diff --git a/requirements.txt b/requirements.txt index 30ff414fe..cf7b99647 100644 --- a/requirements.txt +++ b/requirements.txt @@ -32,3 +32,4 @@ SQLAlchemy==1.3.23 toml==0.10.2 urllib3==1.26.5 Werkzeug==1.0.1 +Flask-SQLAlchemy \ No newline at end of file diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..8d81a828e 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +13,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +32,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -51,7 +51,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -60,13 +60,14 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == "Task with id of 1 was not found" -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -93,7 +94,7 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -119,7 +120,7 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -131,13 +132,13 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == "Task with id of 1 was not found" - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +153,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -161,15 +162,15 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** - + assert response_body == "Task with id of 1 was not found" assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +187,7 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..651e3aebd 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 959176ceb..f62ebfa50 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -5,7 +5,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -42,7 +42,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -62,7 +62,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -99,7 +99,7 @@ def test_mark_complete_on_completed_task(client, completed_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -119,7 +119,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -128,13 +128,13 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == "Task with id of 1 was not found" - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -143,15 +143,15 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** - + assert response_body == "Task with id of 1 was not found" # Let's add this test for creating tasks, now that # the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_with_valid_completed_at(client): # Act response = client.post("/tasks", json={ @@ -181,7 +181,7 @@ def test_create_task_with_valid_completed_at(client): # Let's add this test for updating tasks, now that # the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_with_completed_at_date(client, completed_task): # Act response = client.put("/tasks/1", json={ diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..b105667a7 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +12,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +29,7 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +46,22 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") + # raise Exception("Complete test") # Assert # ---- Complete Test ---- - # assertion 1 goes here - # assertion 2 goes here + assert response_body == "Goal with id of 1 was not found" + assert response.status_code == 404 # ---- Complete Test ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +80,48 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") + # raise Exception("Complete test") # Act # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + }) + response_body = response.get_json() # Assert # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here + assert response.status_code == 200 + assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal Title" + } + } # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") + # raise Exception("Complete test") # Act # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "tittle": "Updated Goal Title" + }) + response_body = response.get_json() + # Assert # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here + assert response.status_code == 404 + assert response_body == "Goal with id of 1 was not found" # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -124,27 +138,30 @@ def test_delete_goal(client, one_goal): response = client.get("/goals/1") assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** - # **Complete test with assertion about response body*************** + response_body = response.get_json() + assert response_body == "Goal with id of 1 was not found" # ***************************************************************** -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") + # raise Exception("Complete test") # Act # ---- Complete Act Here ---- + response = client.delete("/goals/1") + response_body = response.get_json() # Assert # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here + assert response_body == "Goal with id of 1 was not found" + assert response.status_code == 404 # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 8afa4325e..9775d87b7 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -23,7 +23,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(Goal.query.get(1).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -42,7 +42,7 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on assert len(Goal.query.get(1).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -51,13 +51,13 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** - # **Complete test with assertion about response body*************** + assert response_body == "Goal with id of 1 was not found" # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -74,7 +74,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -99,7 +99,7 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()