diff --git a/Procfile b/Procfile new file mode 100644 index 000000000..066ed31d9 --- /dev/null +++ b/Procfile @@ -0,0 +1 @@ +web: gunicorn 'app:create_app()' diff --git a/app/__init__.py b/app/__init__.py index 2764c4cc8..8ea1ec3a5 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -28,7 +28,15 @@ def create_app(test_config=None): db.init_app(app) migrate.init_app(app, db) + # Register Blueprints here + + from .routes import tasks_bp + app.register_blueprint(tasks_bp) + from .goal_routes import goal_bp + app.register_blueprint(goal_bp) + + return app diff --git a/app/goal_routes.py b/app/goal_routes.py new file mode 100644 index 000000000..eee857541 --- /dev/null +++ b/app/goal_routes.py @@ -0,0 +1,123 @@ +from flask import Blueprint, make_response, request, jsonify, abort +from app.models.goal import Goal +from app import db +from flask import request +from datetime import datetime +from app.models.task import Task +# datetime.datetime.utcnow() + +goal_bp = Blueprint("goal_bp", __name__, url_prefix = "/goals") + + +def validate_goal(id_): + try: + id_ = int(id_) + except: + abort(make_response({"details": "Invalid data"}, 400)) + + + + goal = Goal.query.get(id_) + # gets the whole row in db with that particular id + + if not goal: + abort(make_response({"message": f"Goal {id_} not found"}, 404)) + + return goal + +@goal_bp.route("", methods=["POST"]) +def create_goal(): + + request_body = request.get_json() + + try: + new_goal = Goal.create(request_body) + + except KeyError: + return abort(make_response({"details": "Invalid data"}, 400)) + + + db.session.add(new_goal) + db.session.commit() + + return make_response(jsonify(new_goal.to_dict()), 201) + + + +@goal_bp.route("", methods=["GET"]) +def get_goals(): + goals = Goal.query.all() + goals_response = [] + for goal in goals: + goals_response.append( + { + "id": goal.id, + "title": goal.title + } + ) + + return jsonify(goals_response), 200 + +@goal_bp.route("//tasks", methods=["GET"]) +def get_task_with_one_goal(goal_id): + goal = validate_goal(goal_id) + + tasks_response = [] + for task in goal.tasks: + tasks_response.append(Task.to_json(task)) + # goal["tasks"] = tasks_response + + return jsonify({"id": goal.id, "title": goal.title, "tasks": tasks_response}), 200 + # return jsonify(goal), 200 + +@goal_bp.route("/", methods=["GET"]) +def get_one_goal(id): + goal = validate_goal(id) + + return jsonify(goal.to_dict()), 200 + + +@goal_bp.route("/", methods=["PUT"]) +def update_goal(id): + goal = validate_goal(id) + + request_body = request.get_json() + + goal.update(request_body) + + db.session.commit() + + return jsonify(goal.to_dict()), 200 + + +@goal_bp.route("/", methods=["DELETE"]) +def delete_goal(id): + goal = validate_goal(id) + + db.session.delete(goal) + db.session.commit() + + return make_response(jsonify({"details": f"Goal {id} \"{goal.title}\" successfully deleted"}), 200) + +@goal_bp.route("//tasks", methods=["POST"]) +def create_task_with_goal(goal_id): + goal = validate_goal(goal_id) + request_body = request.get_json() + # new_task = Task.create(request_body) + task_ids = request_body["task_ids"] + + for task_id in task_ids: + task = Task.query.get(task_id) + task.goal_id = goal_id + + db.session.commit() + + goal_response = { + "id": goal.id, + "task_ids": task_ids + } + + # return make_response(jsonify({"id": goal.id, "task_ids": task_ids}), 200) + return make_response(jsonify(goal_response), 200) + + diff --git a/app/models/goal.py b/app/models/goal.py index b0ed11dd8..33265c3a3 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -1,5 +1,28 @@ from app import db + class Goal(db.Model): - goal_id = db.Column(db.Integer, primary_key=True) + id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String, nullable=False) + tasks = db.relationship("Task", back_populates="goal", lazy=True) + + + def to_dict(self): + return {"goal": { + "id": self.id, + "title": self.title + } + } + + + def update(self, req_body): + self.title = req_body["title"] + + + @classmethod + def create(cls, req_body): + new_goal = cls( + title=req_body["title"] + ) + return new_goal \ No newline at end of file diff --git a/app/models/task.py b/app/models/task.py index c91ab281f..c70b5dcbf 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,51 @@ + from app import db +# import datetime class Task(db.Model): task_id = db.Column(db.Integer, primary_key=True) + title = db.Column(db.String) + description = db.Column(db.String) + completed_at = db.Column(db.DateTime, nullable = True) + goal_id = db.Column(db.Integer, db.ForeignKey('goal.id'), nullable=True) + goal = db.relationship("Goal", back_populates="tasks") + + def to_json(self): + # change name to_dict(self): + is_complete = False + # if (self.completed_at is not None): + if (self.completed_at is not None): + is_complete = True + task = { + # "task_id": self.task_id, + "id": self.task_id, + "title": self.title, + "description": self.description, + "is_complete": is_complete + } + if self.goal: + # task["goal"] = self.goal.title + task["goal_id"] = self.goal.id + return task + + def update(self, req_body): + self.title = req_body["title"] + self.description = req_body["description"] + # self.completed_at = req_body["is_complete"] + # check to see if this needs to be here or not + + @classmethod + def create(cls, req_body): + if "completed_at" in req_body: + new_task = cls( + title=req_body["title"], + description=req_body["description"], + completed_at=req_body["completed_at"] + ) + else: + new_task = cls( + title=req_body["title"], + description=req_body["description"] + ) + return new_task diff --git a/app/routes.py b/app/routes.py index 3aae38d49..54760fff4 100644 --- a/app/routes.py +++ b/app/routes.py @@ -1 +1,146 @@ -from flask import Blueprint \ No newline at end of file +from flask import Blueprint, make_response, request, jsonify, abort +from app.models.task import Task +from app import db +import requests +from datetime import datetime +import os +from dotenv import load_dotenv +load_dotenv() + +# datetime.datetime.utcnow() + +tasks_bp = Blueprint("tasks_bp", __name__, url_prefix = "/tasks") + + +def validate_task(id_): + try: + id_ = int(id_) + except: + abort(make_response({"details": "Invalid data"}, 400)) + + + + task = Task.query.get(id_) + # gets the whole row in db with that particular id + + if not task: + abort(make_response({"message": f"Task {id_} not found"}, 404)) + + return task + + +@tasks_bp.route("", methods=["POST"]) +def create_task(): + + request_body = request.get_json() + print(request_body) + try: + new_task = Task.create(request_body) + # new_task = Task(title=request_body["title"], + # description=request_body["description"]) + except KeyError: + return abort(make_response({"details": "Invalid data"}, 400)) + + + db.session.add(new_task) + db.session.commit() + + # return make_response(jsonify(f"Task {new_task.title} successfully created"), 201) + return make_response(jsonify({"task": new_task.to_json()}), 201) + + +@tasks_bp.route("//mark_complete", methods=["PATCH"]) +def mark_task_complete(tasks_id): + task = validate_task(tasks_id) + + # request_body = request.get_json() + # task.completed_at = request_body["completed_at"] + task.completed_at = datetime.utcnow() + + # request_body = request.get_json() + # task.completed_at = response_body["completed_at"] + # task.update(response_body) + + db.session.commit() + + SLACK_BOT_POST_PATH = "https://slack.com/api/chat.postMessage" + + query_params = { + "channel": "test-channel", + "text": f"Someone just completed the task {task.title}" + } + + headers = {"Authorization": os.environ.get("SLACK_BOT_KEY")} + + response_bot = requests.post(SLACK_BOT_POST_PATH, params=query_params, headers=headers) + + return make_response(jsonify({"task": task.to_json()}), 200) + +@tasks_bp.route("//mark_incomplete", methods=["PATCH"]) +def mark_task_incomplete(tasks_id): + task = validate_task(tasks_id) + + task.completed_at = None + + # request_body = request.get_json() + # task.completed_at = response_body["completed_at"] + # task.update(response_body) + + db.session.commit() + + return make_response(jsonify({"task": task.to_json()}), 200) + + +@tasks_bp.route("", methods=["GET"]) +def get_tasks(): + title_param = request.args.get("title") + + sort_param = request.args.get("sort") + + if title_param: + tasks = Task.query.filter_by(title=title_param) + else: + if sort_param == "desc": + tasks = Task.query.order_by(Task.title.desc()).all() + else: + # tasks = Task.query.all() + tasks = Task.query.order_by(Task.title.asc()).all() + + + task_response_body = [] + for task in tasks: + task_response_body.append(task.to_json()) + + # [task.tojson() for task in tasks] + + return jsonify(task_response_body), 200 + + + +@tasks_bp.route("/", methods=["GET"]) +def read_one_task(task_id): + task = validate_task(task_id) + + return jsonify({"task": task.to_json()}), 200 + +@tasks_bp.route("/", methods=["PUT"]) +def update_planet(task_id): + task = validate_task(task_id) + + request_body = request.get_json() + + task.update(request_body) + + db.session.commit() + + return make_response(jsonify({"task": task.to_json()}), 200) + +@tasks_bp.route("/", methods=["DELETE"]) +def delete_task(task_id): + task = validate_task(task_id) + + db.session.delete(task) + db.session.commit() + + return make_response(jsonify({"details": f"Task {task_id} \"{task.title}\" successfully deleted"}), 200) + diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/52bae622bad0_established_tasks_goal_relationship.py b/migrations/versions/52bae622bad0_established_tasks_goal_relationship.py new file mode 100644 index 000000000..e191278fa --- /dev/null +++ b/migrations/versions/52bae622bad0_established_tasks_goal_relationship.py @@ -0,0 +1,30 @@ +"""established tasks/goal relationship + +Revision ID: 52bae622bad0 +Revises: c9751d65b732 +Create Date: 2022-05-12 14:34:07.046222 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '52bae622bad0' +down_revision = 'c9751d65b732' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('task', sa.Column('goal_id', sa.Integer(), nullable=True)) + op.create_foreign_key(None, 'task', 'goal', ['goal_id'], ['id']) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_constraint(None, 'task', type_='foreignkey') + op.drop_column('task', 'goal_id') + # ### end Alembic commands ### diff --git a/migrations/versions/c9751d65b732_dropped_and_created_new_db.py b/migrations/versions/c9751d65b732_dropped_and_created_new_db.py new file mode 100644 index 000000000..a6d4b243e --- /dev/null +++ b/migrations/versions/c9751d65b732_dropped_and_created_new_db.py @@ -0,0 +1,40 @@ +"""dropped and created new db + +Revision ID: c9751d65b732 +Revises: +Create Date: 2022-05-12 13:54:58.267173 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'c9751d65b732' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=False), + sa.PrimaryKeyConstraint('id') + ) + op.create_table('task', + sa.Column('task_id', sa.Integer(), nullable=False), + sa.Column('title', sa.String(), nullable=True), + sa.Column('description', sa.String(), nullable=True), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.PrimaryKeyConstraint('task_id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/requirements.txt b/requirements.txt index 30ff414fe..9211f14af 100644 --- a/requirements.txt +++ b/requirements.txt @@ -5,6 +5,7 @@ blinker==1.4 certifi==2020.12.5 chardet==4.0.0 click==7.1.2 +coverage==6.3.2 Flask==1.1.2 Flask-Migrate==2.6.0 Flask-SQLAlchemy==2.4.4 @@ -17,7 +18,7 @@ Mako==1.1.4 MarkupSafe==1.1.1 packaging==20.9 pluggy==0.13.1 -psycopg2-binary==2.8.6 +psycopg2-binary==2.9.3 py==1.10.0 pycodestyle==2.6.0 pyparsing==2.4.7 diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..cd20d4dd4 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +13,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +32,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -51,7 +51,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -60,13 +60,14 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == {"message": "Task 1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -93,7 +94,7 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -119,7 +120,7 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -131,13 +132,14 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == {"message": "Task 1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +154,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -161,15 +163,16 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** assert Task.query.all() == [] + assert response_body == {"message": "Task 1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +189,7 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..651e3aebd 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 959176ceb..63f62e512 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -5,7 +5,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -42,7 +42,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -62,7 +62,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -99,7 +99,7 @@ def test_mark_complete_on_completed_task(client, completed_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -119,7 +119,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -128,13 +128,15 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + + assert response_body == {"message": "Task 1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -143,15 +145,16 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == {"message": "Task 1 not found"} # Let's add this test for creating tasks, now that # the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_with_valid_completed_at(client): # Act response = client.post("/tasks", json={ @@ -181,7 +184,7 @@ def test_create_task_with_valid_completed_at(client): # Let's add this test for updating tasks, now that # the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_with_completed_at_date(client, completed_task): # Act response = client.put("/tasks/1", json={ diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..487c3f56e 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,9 @@ import pytest +from app.models.goal import Goal -@pytest.mark.skip(reason="No way to test this feature yet") + +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +14,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +31,7 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +48,23 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): - pass + # pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") + # raise Exception("Complete test") # Assert # ---- Complete Test ---- # assertion 1 goes here # assertion 2 goes here # ---- Complete Test ---- + assert response_body == {"message": "Goal 1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +83,56 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") + # raise Exception("Complete test") # Act # ---- Complete Act Here ---- - + response = client.put("/goals/1", json={ + "title": "Updated Goal Title", + }) + response_body = response.get_json() # Assert # ---- Complete Assertions Here ---- # assertion 1 goes here + assert response.status_code == 200 # assertion 2 goes here + assert "goal" in response_body # assertion 3 goes here + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal Title", + } + } + goal = Goal.query.get(1) + assert goal.title == "Updated Goal Title" # ---- Complete Assertions Here ---- + + # Assert + + - -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") + # raise Exception("Complete test") # Act # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + }) + response_body = response.get_json() # Assert # ---- Complete Assertions Here ---- # assertion 1 goes here + assert response.status_code == 404 # assertion 2 goes here + assert response_body == {"message": "Goal 1 not found"} # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -124,27 +149,31 @@ def test_delete_goal(client, one_goal): response = client.get("/goals/1") assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert Goal.query.get(1) == None - -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") + # raise Exception("Complete test") # Act # ---- Complete Act Here ---- - + response = client.delete("/goals/1") + response_body = response.get_json() # Assert # ---- Complete Assertions Here ---- # assertion 1 goes here + assert response.status_code == 404 + # assertion 2 goes here + assert response_body == {"message": "Goal 1 not found"} # ---- Complete Assertions Here ---- + # assert Goal.query.all() == [] - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 8afa4325e..6ed95ffe3 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -23,7 +23,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(Goal.query.get(1).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -42,7 +42,7 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on assert len(Goal.query.get(1).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -51,13 +51,14 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** + assert response_body == {"message": "Goal 1 not found"} # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -74,7 +75,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -99,7 +100,7 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()