forked from AdaGold/solar-system-api
-
Notifications
You must be signed in to change notification settings - Fork 11
Mw 08 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MelodyW2022
wants to merge
68
commits into
ada-ac2:main
Choose a base branch
from
dnabilali:MW_08
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mw 08 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onexistent planet id
…_id> and POST /planets routes. refactored the planet_id validation function.
…to commit update to db
mass datatype converted to float. table for Planet is renamed "planets".
…eated a migration file for changing the mass datatype to string
… mass data type is float.
…ction to separate param kwargs for SQLAlchemy query function
La wave05 query params
…_.py to accept dev and test db. added test_get_all_planets_with_empty_db_returns_empty_list
created 3 fixtures:app, client, two_saved_planets.updated app/__init_…
La wave05 query params
…essfully, get planet/<id> with an invalid id
added tests for get /planet/<id> with an empty db, update planet succ…
Added unit tests 3, 6, and 3 edge cases for get method with query kwa…
La wave07 to dict refactor
Mw wave07
Wave8 moon model and routes
…el, changed the imports test_routes file to reflect the routes directory restructuring, added an __init__.py file to routes directory
… moon model and added a validation to make sure the request body has all the required attributes for the moon
updated POST planets/<planet_id>/moons to
feat: Create nested route - Get all moons by planed_id
…last-checks La refactor moon from dict and last checks
…point and POST moons endpoint
of test_create_one_planet_missing_mass_return_400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.