Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form validations to all create flows #841

Open
2 tasks done
andrewtavis opened this issue Apr 25, 2024 · 8 comments
Open
2 tasks done

Add form validations to all create flows #841

andrewtavis opened this issue Apr 25, 2024 · 8 comments
Assignees
Labels
-priority- High priority feature New feature or request

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Apr 25, 2024

Terms

Description

Something that's needed is for all create flows to have form validations such that submission is not possible without certain fields being filled. The following flows need validation:

  • organizations/create
  • groups/create
  • 'resources/create'

Contribution

I'll likely work on this myself, but someone else could also do this so long as they understand that it needs to be done by the end of the weekend :)

@andrewtavis andrewtavis added feature New feature or request -priority- High priority labels Apr 25, 2024
@amilliiee
Copy link
Contributor

I've been doing some digging during work today and I might be able to get this done if you haven't resolved this in any way yet.

@andrewtavis
Copy link
Member Author

Would be happy to get the help, @amilliiee! Will assign you now, and let me know if there's anything I can do to help 😊

@amilliiee
Copy link
Contributor

I think right now the only question I have is how we want this organized. I'm assuming a single validation file?

@andrewtavis
Copy link
Member Author

Would be great, @amilliiee 😊 Thanks for checking in!

@andrewtavis
Copy link
Member Author

andrewtavis commented May 1, 2024

Hey @amilliiee 👋 Looping @to-sta into this discussion as he's working on the login for the backend and we should have shared processes :) Let us know if you're definitely going with formkit and what the plans are 😊 Feedback from both of us is that formkit sounds good!

@amilliiee
Copy link
Contributor

amilliiee commented May 1, 2024

@andrewtavis @to-sta I just figured since it can handle validation on it's own, it would cut down on what we'd need to do to get it working :)

I've been playing around at work and this devbox is a messy first attempt. Since I don't have everything I can't do a full mockup of the create groups page but the general idea is there. There's also a way to condense all of the styling but I need to look into it more.

The topic selection requires the pro version, so if we really do want to go this route I have no problem making the one time payment for it.

Let me know what you guys think, and I can have another go at validation without formkit when I get home today!

Edit:
This is an updated sandbox using the actual site code. I'm trying to figure out the issue of the blank boxes but everything else is formatted the same way the form was

@andrewtavis
Copy link
Member Author

Hey @amilliiee 👋 Sorry for not checking this sooner :) Was gone for a week, and lots to do at work once I was back. Will check this over the weekend, and also feel free to drop into the dev sync tomorrow where we can discuss this as a group 😊

CC @momanyisamuel, this is the issue that's looking at form validation :)

@andrewtavis
Copy link
Member Author

Hey @amilliiee 👋 We're trying to check the sandbox within the dev sync now, but then we're getting something went wrong... Would you be able to open a PR with the changes? :)

@amilliiee amilliiee mentioned this issue Jun 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority feature New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants