Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different cache file names needed for zstd with or without --long? #542

Open
Vampire opened this issue Aug 5, 2020 · 0 comments
Open

different cache file names needed for zstd with or without --long? #542

Vampire opened this issue Aug 5, 2020 · 0 comments
Labels
bug Something isn't working cache

Comments

@Vampire
Copy link

Vampire commented Aug 5, 2020

To be honest, I didn't try this, just something that came to my mind when having a short look at the sources.
So if this is not an issue actually, just close this.
But as far as the man page of zstd says, if you use --long with a value lager than 27 on compression, you also have to specify it on decompression.

But following the current logic, if you create a cache on a system with new zstd where --long is supported and then try to restore the cache on a system with old zstd where --long is not supported, the decompression will probably fail.
So I think a separate file name for zstd with --long is necessary.

@Vampire Vampire added the bug Something isn't working label Aug 5, 2020
@thboop thboop added the cache label Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cache
Projects
None yet
Development

No branches or pull requests

2 participants