Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be possible to annotate files that are not in the commit #470

Open
mattnewport opened this issue May 19, 2020 · 3 comments
Open
Labels

Comments

@mattnewport
Copy link

Annotations can be generated for errors but if the error is in a file that is not part of the commit then it will just link to a line in an unrelated file that is part of the commit. It should be possible to link to files that are not part of the commit.

A simple example of where this is needed: if I have a C# project with two code files and remove a method from one that is called from the other then I will get a compiler error in the unchanged file that is calling the now removed method. Currently the annotations will display the correct filename the compiler error refers to but will link to the wrong file in the commit rather than to the correct file elsewhere in the repo that wasn't touched in this commit.

As far as I can tell this isn't currently possible. If it is possible it should be documented how for problem matchers.

Describe the enhancement

Annotations should be able to link to a file and line / column number anywhere in the repo and not only in the commit. This should be possible from problem matchers (the context in which I originally ran into this issue).

@mattnewport mattnewport added the enhancement New feature or request label May 19, 2020
@peternewman
Copy link

It does sometimes seem to happen @mattnewport , although I'm not really clear of the logic for when. Annotations are always generated but only show in some PRs, for example here:
https://github.com/peternewman/rdm-app/pull/14/files

See the "Unchanged files with check annotations" section, which is also marked as beta.

@jsg2021
Copy link

jsg2021 commented Aug 6, 2020

It would be nice to have the link go to the file (unchanged or not). Isn't there a tree-view for each commit?

@alanmehio
Copy link

@mattnewport . Any idea if there is a solution to this github beta annotation see this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants