Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arsenal - Fix duping unique attachments on weapons #9937

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Arsenal - Fix duping unique attachments on weapons #9937

wants to merge 1 commit into from

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

@LinkIsGrim LinkIsGrim added the kind/bug-fix Release Notes: **FIXED:** label Apr 7, 2024
@LinkIsGrim LinkIsGrim added this to the 3.17.1 milestone Apr 7, 2024
@LinkIsGrim LinkIsGrim requested a review from johnb432 April 7, 2024 17:51
@johnb432
Copy link
Contributor

johnb432 commented Apr 7, 2024

Do we want to apply the same for mags?

@LinkIsGrim
Copy link
Contributor Author

Sure

@johnb432 johnb432 modified the milestones: 3.17.1, Ongoing Apr 8, 2024
@johnb432
Copy link
Contributor

johnb432 commented Apr 8, 2024

If you select another weapon in the arsenal that doesn't have the attachment as compatible, then select the old weapon again, it doesn't add the attachment to the list of available attachments.

@LinkIsGrim LinkIsGrim marked this pull request as draft May 23, 2024 12:55
@LinkIsGrim
Copy link
Contributor Author

Can't fix above without a rewrite of how we handle unique items (use quantity?)

@johnb432
Copy link
Contributor

Can't fix above without a rewrite of how we handle unique items (use quantity?)

Maybe, but I imagine it wouldn't be easy.

@johnb432 johnb432 removed their request for review November 3, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
Ongoing
Development

Successfully merging this pull request may close these issues.

Limited arsenal and any available attachment
2 participants
@LinkIsGrim @johnb432