Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider patool test suite for extractcode #15

Open
pombredanne opened this issue Jan 31, 2017 · 3 comments
Open

Consider patool test suite for extractcode #15

pombredanne opened this issue Jan 31, 2017 · 3 comments

Comments

@pombredanne
Copy link
Member

See https://github.com/wummel/patool/tree/master/tests/data for more tests cases.

@darkknightawakens
Copy link

darkknightawakens commented Mar 4, 2017

@pombredanne i would like to work on this issue.

@michaelrup
Copy link
Contributor

I've just created a PR aboutcode-org/scancode-toolkit#546 for a single test case from the patool test suite to check if this is the right of implementing a new test case. If everything checks out I will work on adding more test cases.

@pombredanne
Copy link
Member Author

@michaelrup great PR, and this is the right approach alright. Since in this case we borrow test archives files, we just need to credit @wummel and make sure we handle these properly as GPL-licensed test files from https://github.com/wummel/patool as I explained in aboutcode-org/scancode-toolkit#546 (review)

@wummel: just a heads up @michaelrup is adding new tests for scancode's own extraction code using your own test archives for patool.

pombredanne referenced this issue in aboutcode-org/scancode-toolkit Mar 8, 2017
#473 Consider patool test suite for extractcode
pombredanne referenced this issue in aboutcode-org/scancode-toolkit Mar 10, 2017
#473 Consider patool test suite for extractcode
@pombredanne
Copy link
Member Author

@michaelrup any plan for you to add more tests to this?

@pombredanne pombredanne transferred this issue from aboutcode-org/scancode-toolkit Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants