Add Objects flags, channel modes and message types #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mschristensen
approved these changes
Apr 17, 2025
…de initial value for an object
This was referenced May 16, 2025
sacOO7
reviewed
May 23, 2025
sacOO7
reviewed
May 27, 2025
sacOO7
reviewed
May 27, 2025
sacOO7
reviewed
May 27, 2025
sacOO7
reviewed
May 27, 2025
sacOO7
reviewed
May 27, 2025
sacOO7
reviewed
May 27, 2025
sacOO7
reviewed
May 28, 2025
VeskeR
added a commit
that referenced
this pull request
May 29, 2025
It should never have been named `map`, it was a type in #298
sacOO7
reviewed
May 29, 2025
lawrence-forooghian
pushed a commit
that referenced
this pull request
Jun 5, 2025
It should never have been named `map`, it was a type in #298
sacOO7
reviewed
Jun 5, 2025
VeskeR
added a commit
that referenced
this pull request
Jun 5, 2025
It should never have been named `map`, it was a type in #298
sacOO7
reviewed
Jun 6, 2025
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Jun 20, 2025
…Message class Based on the spec added in [1], and updates to the spec made in [2] and [3] [1] ably/specification#298 [2] ably/specification#327 [3] ably/specification#328
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Jun 26, 2025
…Message class Based on the spec added in [1], and updates to the spec made in [2] and [3] [1] ably/specification#298 [2] ably/specification#327 [3] ably/specification#328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the https://github.com/ably/specification/tree/integration/objects branch rebased onto the current
main. Decided to rebase instead of mergingmaininto theintegration/objectsto avoid a merge commit and preserve a cleaner history. Justified in this case as we only ever merged #279 PR into theintegration/objectsbranch, so we're not losing much PR history by rebasing.How to review:
ac11798 and 72cc202 commits were reviewed as part of the #279 PR (ref lost due to rebase) and there is no need to re-review. These added protocol message flags, channel modes and message types for Objects.
This PR also adds 4 small commits to fix some minor issues and reserve spec points for the Objects spec itself. Please review next commits (couple of lines each):
121a226
2730578
ebc51b6
23903db
This PR also bumps the specification version to
3.1.0in 19f3fcd