[EDU-2056] Add webhook concurrency limit #2798
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| | ----------------- | ---- | -------- | --- | ---------- | | ||
| | **Integration rate (per second)**<p>*the maximum rate at which integrations can be executed, or streamed*</p> | 250 | 250 | 1,000 | Custom | | ||
| | **Integration concurrency (Google Functions and Azure)**<p>*the maximum number of integrations that can run at the same time*</p> | 25 | 25 | 100 | Custom | | ||
| | **Webhook concurrency**<p>*the maximum number of webhook requests that can be processed at the same time*</p> | 25 | 25 | 100 | Custom | |
There was a problem hiding this comment.
the maximum number of webhook requests that can be processed at the same time
Not sure this captures it. It implies we're processing something, but the whole point with this limit is that it's the customer processing it. Maybe "The maximum number of unbatched webhook requests that can be in-flight at any one time from a given source"?
Also I'm not sure I understand the reasoning for presenting this one limit as two different ones.
(and indeed the one above is probably out of date since the limit only applies to http1 unbatched webhooks but google functions and azure endpoints probably accept http2 these days)
There was a problem hiding this comment.
I've picked this one up @SimonWoolf. Does this new edit match your thoughts here? 8ba6be3
franrob-projects
left a comment
franrob-projects
left a comment
There was a problem hiding this comment.
I've picked this one up @SimonWoolf @m-hulbert !
| | ----------------- | ---- | -------- | --- | ---------- | | ||
| | **Integration rate (per second)**<p>*the maximum rate at which integrations can be executed, or streamed*</p> | 250 | 250 | 1,000 | Custom | | ||
| | **Integration concurrency (Google Functions and Azure)**<p>*the maximum number of integrations that can run at the same time*</p> | 25 | 25 | 100 | Custom | | ||
| | **Webhook concurrency**<p>*the maximum number of webhook requests that can be processed at the same time*</p> | 25 | 25 | 100 | Custom | |
There was a problem hiding this comment.
I've picked this one up @SimonWoolf. Does this new edit match your thoughts here? 8ba6be3
| | **Integration rate (per second)**<p>*the maximum rate at which integrations can be executed, or streamed*</p> | 250 | 250 | 1,000 | Custom | | ||
| | **Integration concurrency (Google Functions and Azure)**<p>*the maximum number of integrations that can run at the same time*</p> | 25 | 25 | 100 | Custom | | ||
| | **Integration concurrency (HTTP/1 unbatched webhooks)**<p>*the maximum number of HTTP/1 unbatched webhook integrations that can run at the same time*</p> | 25 | 25 | 100 | Custom | | ||
| | **Webhook concurrency**<p>*the maximum number of unbatched webhook requests that can be in-flight at any one time from a given source*</p> | 25 | 25 | 100 | Custom | |
There was a problem hiding this comment.
what's the intended difference between these two lines?
Description
This PR adds a missing limit for webhook concurrency to the limits page.
Checklist