Skip to content

Commit b352c1a

Browse files
Merge pull request #70 from ably/rename-repo-to-ably-liveobjects-swift-plugin
Update for renamed repo
2 parents 604a89e + a54eb3c commit b352c1a

18 files changed

+43
-43
lines changed

.github/workflows/check.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040

4141
- run: swift run BuildTool lint
4242

43-
# TODO: Restore in https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/2 once we've seen what form the LiveObjects spec takes
43+
# TODO: Restore in https://github.com/ably/ably-liveobjects-swift-plugin/issues/2 once we've seen what form the LiveObjects spec takes
4444
#
4545
# spec-coverage:
4646
# runs-on: macos-15
@@ -254,7 +254,7 @@ jobs:
254254
uses: aws-actions/configure-aws-credentials@v4
255255
with:
256256
aws-region: eu-west-2
257-
role-to-assume: arn:aws:iam::${{ secrets.ABLY_AWS_ACCOUNT_ID_SDK }}:role/ably-sdk-builds-ably-cocoa-liveobjects-plugin
257+
role-to-assume: arn:aws:iam::${{ secrets.ABLY_AWS_ACCOUNT_ID_SDK }}:role/ably-sdk-builds-ably-liveobjects-swift-plugin
258258
role-session-name: "${{ github.run_id }}-${{ github.run_number }}"
259259

260260
# Upload the generated documentation

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ Example:
127127

128128
For the initial stage of development of this plugin, where we need to also iterate heavily on ably-cocoa, I've added ably-cocoa as a Git submodule, which can be found in [`ably-cocoa`](./ably-cocoa). This allows you to edit ably-cocoa from within this repo's Xcode workspace.
129129

130-
Nearer launch, we'll remove this submodule in https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/7.
130+
Nearer launch, we'll remove this submodule in https://github.com/ably/ably-liveobjects-swift-plugin/issues/7.
131131

132132
## Release process
133133

@@ -137,7 +137,7 @@ For each release, the following needs to be done:
137137
- Update the following (we have https://github.com/ably/ably-chat-swift/issues/277 for adding a script to do this):
138138
- the `version` constant in [`Sources/AblyLiveObjects/Version.swift`](Sources/AblyLiveObjects/Version.swift)
139139
- the `from: "…"` in the SPM installation instructions in [`README.md`](README.md)
140-
- Go to [Github releases](https://github.com/ably/ably-cocoa-liveobjects-plugin/releases) and press the `Draft a new release` button. Choose your new branch as a target
140+
- Go to [Github releases](https://github.com/ably/ably-liveobjects-swift-plugin/releases) and press the `Draft a new release` button. Choose your new branch as a target
141141
- Press the `Choose a tag` dropdown and start typing a new tag, Github will suggest the `Create new tag x.x.x on publish` option. After you select it Github will unveil the `Generate release notes` button
142142
- From the newly generated changes remove everything that don't make much sense to the library user
143143
- Copy the final list of changes to the top of the `CHANGELOG.md` file. Modify as necessary to fit the existing format of this file

Sources/AblyLiveObjects/Internal/CoreSDK.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ internal final class DefaultCoreSDK: CoreSDK {
6666
return
6767
}
6868

69-
// TODO: Implement the full spec of RTO15 (https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/47)
69+
// TODO: Implement the full spec of RTO15 (https://github.com/ably/ably-liveobjects-swift-plugin/issues/47)
7070
try await DefaultInternalPlugin.sendObject(
7171
objectMessages: objectMessages,
7272
channel: channel,

Sources/AblyLiveObjects/Internal/InternalDefaultLiveCounter.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import Foundation
44

55
/// This provides the implementation behind ``PublicDefaultLiveCounter``, via internal versions of the ``LiveCounter`` API.
66
internal final class InternalDefaultLiveCounter: Sendable {
7-
// Used for synchronizing access to all of this instance's mutable state. This is a temporary solution just to allow us to implement `Sendable`, and we'll revisit it in https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/3.
7+
// Used for synchronizing access to all of this instance's mutable state. This is a temporary solution just to allow us to implement `Sendable`, and we'll revisit it in https://github.com/ably/ably-liveobjects-swift-plugin/issues/3.
88
private let mutex = NSLock()
99

1010
private nonisolated(unsafe) var mutableState: MutableState

Sources/AblyLiveObjects/Internal/InternalDefaultLiveMap.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ internal protocol LiveMapObjectPoolDelegate: AnyObject, Sendable {
99

1010
/// This provides the implementation behind ``PublicDefaultLiveMap``, via internal versions of the ``LiveMap`` API.
1111
internal final class InternalDefaultLiveMap: Sendable {
12-
// Used for synchronizing access to all of this instance's mutable state. This is a temporary solution just to allow us to implement `Sendable`, and we'll revisit it in https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/3.
12+
// Used for synchronizing access to all of this instance's mutable state. This is a temporary solution just to allow us to implement `Sendable`, and we'll revisit it in https://github.com/ably/ably-liveobjects-swift-plugin/issues/3.
1313
private let mutex = NSLock()
1414

1515
private nonisolated(unsafe) var mutableState: MutableState
@@ -905,7 +905,7 @@ internal final class InternalDefaultLiveMap: Sendable {
905905
return .string(string)
906906
}
907907

908-
// TODO: Needs specification (see https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/46)
908+
// TODO: Needs specification (see https://github.com/ably/ably-liveobjects-swift-plugin/issues/46)
909909
if let json = entry.data?.json {
910910
switch json {
911911
case let .array(array):

Sources/AblyLiveObjects/Internal/InternalDefaultRealtimeObjects.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import Ably
33

44
/// This provides the implementation behind ``PublicDefaultRealtimeObjects``, via internal versions of the ``RealtimeObjects`` API.
55
internal final class InternalDefaultRealtimeObjects: Sendable, LiveMapObjectPoolDelegate {
6-
// Used for synchronizing access to all of this instance's mutable state. This is a temporary solution just to allow us to implement `Sendable`, and we'll revisit it in https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/3.
6+
// Used for synchronizing access to all of this instance's mutable state. This is a temporary solution just to allow us to implement `Sendable`, and we'll revisit it in https://github.com/ably/ably-liveobjects-swift-plugin/issues/3.
77
private let mutex = NSLock()
88

99
private nonisolated(unsafe) var mutableState: MutableState!
@@ -168,7 +168,7 @@ internal final class InternalDefaultRealtimeObjects: Sendable, LiveMapObjectPool
168168
}
169169

170170
// RTO11f
171-
// TODO: This is a stopgap; change to use server time per RTO11f5 (https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/50)
171+
// TODO: This is a stopgap; change to use server time per RTO11f5 (https://github.com/ably/ably-liveobjects-swift-plugin/issues/50)
172172
let timestamp = clock.now
173173
let creationOperation = ObjectCreationHelpers.creationOperationForLiveMap(
174174
entries: entries,
@@ -213,7 +213,7 @@ internal final class InternalDefaultRealtimeObjects: Sendable, LiveMapObjectPool
213213

214214
// RTO12f
215215

216-
// TODO: This is a stopgap; change to use server time per RTO12f5 (https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/50)
216+
// TODO: This is a stopgap; change to use server time per RTO12f5 (https://github.com/ably/ably-liveobjects-swift-plugin/issues/50)
217217
let timestamp = clock.now
218218
let creationOperation = ObjectCreationHelpers.creationOperationForLiveCounter(
219219
count: count,

Sources/AblyLiveObjects/Internal/InternalLiveMapValue.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ internal enum InternalLiveMapValue: Sendable, Equatable {
3232
self = .jsonObject(value)
3333
case let .liveMap(publicLiveMap):
3434
guard let publicDefaultLiveMap = publicLiveMap as? PublicDefaultLiveMap else {
35-
// TODO: Try and remove this runtime check and know this type statically, see https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/37
35+
// TODO: Try and remove this runtime check and know this type statically, see https://github.com/ably/ably-liveobjects-swift-plugin/issues/37
3636
preconditionFailure("Expected PublicDefaultLiveMap, got \(publicLiveMap)")
3737
}
3838
self = .liveMap(publicDefaultLiveMap.proxied)
3939
case let .liveCounter(publicLiveCounter):
4040
guard let publicDefaultLiveCounter = publicLiveCounter as? PublicDefaultLiveCounter else {
41-
// TODO: Try and remove this runtime check and know this type statically, see https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/37
41+
// TODO: Try and remove this runtime check and know this type statically, see https://github.com/ably/ably-liveobjects-swift-plugin/issues/37
4242
preconditionFailure("Expected PublicDefaultLiveCounter, got \(publicLiveCounter)")
4343
}
4444
self = .liveCounter(publicDefaultLiveCounter.proxied)

Sources/AblyLiveObjects/Internal/ObjectsPool.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ internal struct ObjectsPool {
326326
case let .counter(counter):
327327
return counter
328328
case .map:
329-
// TODO: Add the ability to statically reason about the type of pool entries in https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/36
329+
// TODO: Add the ability to statically reason about the type of pool entries in https://github.com/ably/ably-liveobjects-swift-plugin/issues/36
330330
preconditionFailure("Expected counter object with ID \(creationOperation.objectID) but found map object")
331331
}
332332
}
@@ -370,7 +370,7 @@ internal struct ObjectsPool {
370370
case let .map(map):
371371
return map
372372
case .counter:
373-
// TODO: Add the ability to statically reason about the type of pool entries in https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/36
373+
// TODO: Add the ability to statically reason about the type of pool entries in https://github.com/ably/ably-liveobjects-swift-plugin/issues/36
374374
preconditionFailure("Expected map object with ID \(creationOperation.objectID) but found counter object")
375375
}
376376
}

Sources/AblyLiveObjects/Protocol/ObjectMessage.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ internal struct ObjectData: Equatable {
6060
internal var bytes: Data? // OD2d
6161
internal var number: NSNumber? // OD2e
6262
internal var string: String? // OD2f
63-
internal var json: JSONObjectOrArray? // TODO: Needs specification (see https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/46)
63+
internal var json: JSONObjectOrArray? // TODO: Needs specification (see https://github.com/ably/ably-liveobjects-swift-plugin/issues/46)
6464
}
6565

6666
internal struct ObjectsMapOp: Equatable {
@@ -289,7 +289,7 @@ internal extension ObjectData {
289289
}
290290
}
291291

292-
// TODO: Needs specification (see https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/46)
292+
// TODO: Needs specification (see https://github.com/ably/ably-liveobjects-swift-plugin/issues/46)
293293
if let wireJson = wireObjectData.json {
294294
let jsonValue = try JSONObjectOrArray(jsonString: wireJson)
295295
json = jsonValue
@@ -340,7 +340,7 @@ internal extension ObjectData {
340340
// OD4c4: A string payload is encoded as a MessagePack string type, and the result is set on the ObjectData.string attribute
341341
// OD4d4: A string payload is represented as a JSON string and set on the ObjectData.string attribute
342342
string: string,
343-
// TODO: Needs specification (see https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/46)
343+
// TODO: Needs specification (see https://github.com/ably/ably-liveobjects-swift-plugin/issues/46)
344344
json: json?.toJSONString,
345345
)
346346
}

Sources/AblyLiveObjects/Protocol/WireObjectMessage.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ internal struct WireObjectData {
476476
internal var bytes: StringOrData? // OD2d
477477
internal var number: NSNumber? // OD2e
478478
internal var string: String? // OD2f
479-
internal var json: String? // TODO: Needs specification (see https://github.com/ably/ably-cocoa-liveobjects-plugin/issues/46)
479+
internal var json: String? // TODO: Needs specification (see https://github.com/ably/ably-liveobjects-swift-plugin/issues/46)
480480
}
481481

482482
extension WireObjectData: WireObjectCodable {

0 commit comments

Comments
 (0)