Skip to content

Commit 7a2379c

Browse files
Suppress deletion of updateSelfLater argument label
Should have done this in ad60504 and 40b2d86. We do this for clarity so that this closure doesn't look like a listener, same as in the existing `subscribe` methods.
1 parent 5c6ff74 commit 7a2379c

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

Sources/AblyLiveObjects/Internal/InternalDefaultLiveCounter.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,15 +152,16 @@ internal final class InternalDefaultLiveCounter: Sendable {
152152
@discardableResult
153153
internal func on(event: LiveObjectLifecycleEvent, callback: @escaping LiveObjectLifecycleEventCallback) -> any OnLiveObjectLifecycleEventResponse {
154154
mutex.withLock {
155-
mutableState.liveObjectMutableState.on(event: event, callback: callback) { [weak self] action in
155+
// swiftlint:disable:next trailing_closure
156+
mutableState.liveObjectMutableState.on(event: event, callback: callback, updateSelfLater: { [weak self] action in
156157
guard let self else {
157158
return
158159
}
159160

160161
mutex.withLock {
161162
action(&mutableState.liveObjectMutableState)
162163
}
163-
}
164+
})
164165
}
165166
}
166167

Sources/AblyLiveObjects/Internal/InternalDefaultLiveMap.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,15 +221,16 @@ internal final class InternalDefaultLiveMap: Sendable {
221221
@discardableResult
222222
internal func on(event: LiveObjectLifecycleEvent, callback: @escaping LiveObjectLifecycleEventCallback) -> any OnLiveObjectLifecycleEventResponse {
223223
mutex.withLock {
224-
mutableState.liveObjectMutableState.on(event: event, callback: callback) { [weak self] action in
224+
// swiftlint:disable:next trailing_closure
225+
mutableState.liveObjectMutableState.on(event: event, callback: callback, updateSelfLater: { [weak self] action in
225226
guard let self else {
226227
return
227228
}
228229

229230
mutex.withLock {
230231
action(&mutableState.liveObjectMutableState)
231232
}
232-
}
233+
})
233234
}
234235
}
235236

Sources/AblyLiveObjects/Internal/InternalDefaultRealtimeObjects.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,15 +245,16 @@ internal final class InternalDefaultRealtimeObjects: Sendable, LiveMapObjectPool
245245
@discardableResult
246246
internal func on(event: ObjectsEvent, callback: @escaping ObjectsEventCallback) -> any OnObjectsEventResponse {
247247
mutex.withLock {
248-
mutableState.on(event: event, callback: callback) { [weak self] action in
248+
// swiftlint:disable:next trailing_closure
249+
mutableState.on(event: event, callback: callback, updateSelfLater: { [weak self] action in
249250
guard let self else {
250251
return
251252
}
252253

253254
mutex.withLock {
254255
action(&mutableState)
255256
}
256-
}
257+
})
257258
}
258259
}
259260

0 commit comments

Comments
 (0)