Skip to content

Commit 70acf92

Browse files
authored
Merge pull request #675 from ably/fix-connection-id-test
tests: Don't assert connection key equality
2 parents a81632d + 1159986 commit 70acf92

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

ably/realtime_conn_spec_integration_test.go

+1-6
Original file line numberDiff line numberDiff line change
@@ -1947,9 +1947,8 @@ func TestRealtimeConn_RTN16(t *testing.T) {
19471947
assert.NoError(t, err)
19481948

19491949
{ // RTN16f, RTN16j, RTN16d
1950-
assert.True(t, sameConnection(client.Connection.Key(), c.Connection.Key()),
1950+
assert.Equal(t, prevConnId, client.Connection.ID(),
19511951
"expected the same connection")
1952-
assert.Equal(t, prevConnId, c.Connection.ID())
19531952
assert.Nil(t, client.Connection.ErrorReason())
19541953
assert.Equal(t, prevMsgSerial, client.Connection.MsgSerial(),
19551954
"expected %d got %d", prevMsgSerial, client.Connection.MsgSerial())
@@ -2006,10 +2005,6 @@ func TestRealtimeConn_RTN16(t *testing.T) {
20062005
}
20072006
}
20082007

2009-
func sameConnection(a, b string) bool {
2010-
return strings.Split(a, "-")[0] == strings.Split(b, "-")[0]
2011-
}
2012-
20132008
func TestRealtimeConn_RTN23(t *testing.T) {
20142009
connDetails := ably.ConnectionDetails{
20152010
ConnectionKey: "foo",

0 commit comments

Comments
 (0)