sdist: include .ggml_build_number in tarball #1980
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With that, builds using tarball will still have the correct cmake package version for ggml. This assumes the file is read by llama.cpp build system, see: ggml-org/llama.cpp#12509 Fixes abetlen#1979 Signed-off-by: Ihar Hrachyshka <[email protected]>
booxter
commented
Mar 22, 2025
| @@ -65,7 +65,7 @@ wheel.packages = ["llama_cpp"] | |||
| cmake.verbose = true | |||
| cmake.minimum-version = "3.21" | |||
| minimum-version = "0.5.1" | |||
| sdist.include = [".git", "vendor/llama.cpp/*"] | |||
There was a problem hiding this comment.
I'm not sure why .git was included before. I can build the package even when I remove the directory completely before the build.
|
Will need to figure out how to test the change to github workflow actually works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With that, builds using tarball will still have the correct cmake
package version for ggml.
This assumes the file is read by llama.cpp build system, see:
ggml-org/llama.cpp#12509
Fixes #1979