Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partially integrated ForwardAndRewindStyle #138

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

andrezanna
Copy link
Contributor

I've added a partial integration since I need fastly to update the video player in my app.

@abdelaziz-mahdy
Copy link
Owner

Thank you very much, will check it when I have time, but so far looks good to me .

@abdelaziz-mahdy
Copy link
Owner

hello, your last commit breaks my github actions can you revert it? changing the package folders is a problem for me , also no need to do it like that

you can get it from github and pick the path for the package

@abdelaziz-mahdy
Copy link
Owner

abdelaziz-mahdy commented Jul 18, 2023

example

dependencies:   
     flutter_meedu_videoplayer:
       git:
         url: https://github.com/abdelaziz-mahdy/flutter_meedu_videoplayer
         path: package 

you can put your github url there

This reverts commit 636baed.
@andrezanna andrezanna reopened this Jul 19, 2023
@andrezanna
Copy link
Contributor Author

Hello, sorry for the confusion,

I reverted the commit now.
Didn't know about that git feature you mentioned.

Many Thanks

Andrea

@abdelaziz-mahdy
Copy link
Owner

thank you very much will make sure everything is working as intended and will merge.

@abdelaziz-mahdy
Copy link
Owner

abdelaziz-mahdy commented Jul 23, 2023

image

sorry i took sometime to look into this, i dont mind the changes but the slider is a bit weird? dont you think?
i think it will be better to have same old look using the colortheme, and if people need to have another color they should define it

i like the idea of being able to customize the widgets, so i am just looking for a way that doesnt break old ui on update but also can be customized like how you did it

what do you think?

@abdelaziz-mahdy
Copy link
Owner

let me know what do you think about the new changes, also can you add an example for your changes? like a custom styled screen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants