Merge pull request #67 from mtsonline/fixes

additional fixes

README.md

@@ -21,7 +21,6 @@ You need to set some environment variables to run the container.
 * BBB_STREAM_URL - URL of your streaming server including rtmp. Leave out to disable streaming. (e.g. rtmp://media_server_url/stream/stream_key)
 
 #### Optional settings
-* BBB_AS_MODERATOR - if set to "true" the meeting will be joined as moderator
 * BBB_START_MEETING - start meeting
 * BBB_ATTENDEE_PASSWORD - attendee password (optional - has to be set to the attendee password of moodle/greenlight or any other frontend to allow joining via their links)
 * BBB_MODERATOR_PASSWORD - moderator password (optional - has to be set to the moderator password of moodle/greenlight or any other frontend to allow joining via their links)
@@ -46,6 +45,16 @@ You need to set some environment variables to run the container.
 * docker-compose up -d
 * docker-compose down 
 
+### Chat feedback
+to use the user feedback via chat injection you will have to setup a website wehre the user can write comments and send them to your meeting.
+In the examples folder, there are two files you can use as starting point:
+
+* player_and_chat.php
+place this in a public webpage or create a similar webform that will be send to the processing php file sendChatMessage.php
+
+* sendChatMessage.php
+this file must be reachable by the webform and has to have access to the redis database you configured in your docker-compose file.
+
 ## Known Limitations
 * the streamer does not reconnect, if the connection to BigBlueButton gets lost
 * when using breakoutrooms, the streamer will show the popup of the invitation and not be able to get back to the conference

chat.py

@@ -20,7 +20,6 @@
 parser.add_argument("-s","--server", help="Big Blue Button Server URL")
 parser.add_argument("-p","--secret", help="Big Blue Button Secret")
 parser.add_argument("-i","--id", help="Big Blue Button Meeting ID")
-parser.add_argument("-m","--moderator", help="Join the meeting as moderator",action="store_true")
 parser.add_argument("-S","--startMeeting", help="start the meeting if not running",action="store_true")
 parser.add_argument("-A","--attendeePassword", help="attendee password (required to create meetings)")
 parser.add_argument("-M","--moderatorPassword", help="moderator password (required to create a meeting)")

startStream.sh

@@ -1,10 +1,5 @@
 #!/bin/sh
 
-JOIN_AS_MODERATOR="";
-if [ "${BBB_AS_MODERATOR}" = "true" ]
-then
-   JOIN_AS_MODERATOR="-m";
-fi 
 
 STREAM_MEETING="";
 if [ "${BBB_STREAM_URL}" != "" ]
@@ -43,7 +38,7 @@ then
 fi 
 
 START_MEETING="";
-if [ "${BBB_START_MEETING}" != "" ]
+if [ "${BBB_START_MEETING}" = "true" ]
 then
    START_MEETING="-S";
 fi 
@@ -68,8 +63,8 @@ fi
 
 if [ "${BBB_ENABLE_CHAT}" = "true" ]
 then
-   xvfb-run -n 133 --server-args="-screen 0 1920x1080x24" python3 chat.py -s ${BBB_URL} -p ${BBB_SECRET} -i "${BBB_MEETING_ID}" -r ${BBB_REDIS_HOST} -u "${BBB_CHAT_NAME}" -c ${BBB_REDIS_CHANNEL} $START_MEETING $ATTENDEE_PASSWORD $MODERATOR_PASSWORD -T "$MEETING_TITLE" $JOIN_AS_MODERATOR &
+   xvfb-run -n 133 --server-args="-screen 0 1920x1080x24" python3 chat.py -s ${BBB_URL} -p ${BBB_SECRET} -i "${BBB_MEETING_ID}" -r ${BBB_REDIS_HOST} -u "${BBB_CHAT_NAME}" -c ${BBB_REDIS_CHANNEL} $START_MEETING $ATTENDEE_PASSWORD $MODERATOR_PASSWORD -T "$MEETING_TITLE" &
    sleep 10
 fi 
 
-xvfb-run -n 122 --server-args="-screen 0 1920x1080x24" python3 stream.py -s ${BBB_URL} -p ${BBB_SECRET} -i "${BBB_MEETING_ID}" -u "${BBB_USER_NAME}" ${SHOW_CHAT} $START_MEETING $ATTENDEE_PASSWORD $MODERATOR_PASSWORD -T "$MEETING_TITLE" $STREAM_MEETING $INTRO $BEGIN_INTRO $END_INTRO $JOIN_AS_MODERATOR $DOWNLOAD_MEETING;
+xvfb-run -n 122 --server-args="-screen 0 1920x1080x24" python3 stream.py -s ${BBB_URL} -p ${BBB_SECRET} -i "${BBB_MEETING_ID}" -u "${BBB_USER_NAME}" ${SHOW_CHAT} $START_MEETING $ATTENDEE_PASSWORD $MODERATOR_PASSWORD -T "$MEETING_TITLE" $STREAM_MEETING $INTRO $BEGIN_INTRO $END_INTRO $DOWNLOAD_MEETING;

stream.py

@@ -30,7 +30,6 @@
 parser.add_argument("-E","--endIntroAt", help="End intro at position (e.g. 01:00:04)")
 parser.add_argument("-l","--stream", help="live stream a BigBlueButton meeting",action="store_true")
 parser.add_argument("-d","--download", help="download / save a BigBlueButton meeting",action="store_true")
-parser.add_argument("-m","--moderator", help="Join the meeting as moderator",action="store_true")
 parser.add_argument("-S","--startMeeting", help="start the meeting if not running",action="store_true")
 parser.add_argument("-A","--attendeePassword", help="attendee password (required to create meetings)")
 parser.add_argument("-M","--moderatorPassword", help="moderator password (required to create a meeting)")