Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aaru doesn't parse image file from MDS if the extension specified in the MDS isn't MDF #859

Open
5 of 20 tasks
HeroponRikiBestest opened this issue Dec 10, 2024 · 0 comments

Comments

@HeroponRikiBestest
Copy link

Version

Development commit

Commit hash

f061e8b

Tested debug version?

  • Yes

Which operating systems have you used?

  • Windows
  • Linux
  • macOS
  • Other

What is the architectural bit size you're using?

  • 32-bit
  • 64-bit
  • Unsure or unknown

What processor are you using?

  • An Intel or AMD
  • An ARM or Apple Silicon
  • Unsure or unknown

Image format

MDS

Application that created the image

Alcohol 120%

What were you doing when it failed?

  • I was converting the image to another format...
  • I was retrieving image information...
  • I was retrieving filesystem information...
  • I was listing the filesystem contents...
  • I was extracting the filesystem contents...
  • I was creating a metadata sidecar...
  • I was checksumming the image...
  • I was verifying the image...
  • I was calculating the image entropy...

Destination image format

No response

Filesystem

No response

Description

If an mds file specifies an extension that isn't mdf, aaru will fail to handle the image and close with ENOENT, regardless of whether you give the image file the extension the MDS specifies, or whether you give it the extension MDF.

Exact command line used

aaru i info [name].mds

Expected behavior

For this specific command, I expected aaru to retrieve image information.

There are 3 ways I'd imagine approaching this.

  1. Giving an error that the format specified in the MDS is wrong, and that the user should change it to mdf themselves.
  2. Checking for *.mdf regardless of what the mds file specifies.
  3. Using the extension specified in the mds file

Personally, I'd lean towards 3, as even if a120 doesn't dump to that format, it will still happily mount images based on the extension specified in the mds, and, presumably the extension is specified there for a reason anyways.
Regardless, I'd be ok with any of the options, though.

Actual behavior

Image format identified by Alcohol 120% Media Descriptor Structure 
(a78fbeba-0307-4915-bde3-b8a3b57f843f).

Cannot open data file
Unable to open image format
Error: ENOENT
Uploading statistics

Output of command execution with debug output enabled

aaru i info Mofamen\ Xilie\ Zhi\ Yingxiong\ Wudi\ III\ -\ Mori\ Zhi\ Ren\ \(China\).mds -d
aaru 6.0.0~alpha9+ae8d6e38.ae8d6e385459c0607a137693eca96eb397f89598
Copyright © 2011-2024 Natalia Portillo

DEBUG (Image-info command): --debug=True
DEBUG (Image-info command): --input=Mofamen Xilie Zhi Yingxiong Wudi III - Mori 
Zhi Ren (China).mds
DEBUG (Image-info command): --verbose=False
Cannot open specified file.
Uploading statistics

Affected image

Any MDS specifying something besides *.mdf is affected. So far I've seen *.bin, *.iso, and *.img. (For both single and double byte, obviously).

Mofamen Xilie Zhi Yingxiong Wudi III - Mori Zhi Ren (China).mds.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant