Fix osse-broadcast url in script, add logging on album art fail

Author: aMytho

osse-core/app/Services/MusicProcessor/ArtFile.php

@@ -2,6 +2,7 @@
 
 namespace App\Services\MusicProcessor;
 
+use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Facades\Storage;
 use Kiwilan\Audio\Models\AudioCover;
 use SplFileInfo;
@@ -29,10 +30,14 @@ private function generateHash(): string
     public function storeFile(): void
     {
         if ($this->file instanceof SplFileInfo) {
-            Storage::disk(config('scan.cover_art_disk'))->put('cover-art/'.$this->hash, file_get_contents($this->file->getRealPath()));
+            if (!Storage::disk(config('scan.cover_art_disk'))->put('cover-art/'.$this->hash, file_get_contents($this->file->getRealPath()))) {
+                Log::warning('Failed to store album art for ' . $this->trackFilePath);
+            }
             $this->mimeType = Storage::disk(config('scan.cover_art_disk'))->mimeType('cover-art/'.$this->hash) ?? null;
         } else {
-            Storage::disk(config('scan.cover_art_disk'))->put('cover-art/'.$this->hash, $this->file->getContents());
+            if (!Storage::disk(config('scan.cover_art_disk'))->put('cover-art/'.$this->hash, $this->file->getContents())) {
+                Log::warning('Failed to store album art for ' . $this->trackFilePath);
+            }
             $this->mimeType = $this->file->getMimeType();
         }
     }

osse.sh

@@ -72,7 +72,7 @@ generate_caddy() {
     sed -i "s+WEB_FRONTEND_TEMPLATE+$REPLACE+" Caddyfile
 
     # Use localhost in prod, broadcast container in docker.
-    if [[ -v $OSSE_DOCKER_PORT ]]; then
+    if [ -z $OSSE_DOCKER_PORT ]; then
         REPLACE="reverse_proxy 127.0.0.1:${OSSE_BROADCAST_PORT}"
     else
         REPLACE="reverse_proxy broadcast:${OSSE_BROADCAST_PORT}"