babysitter-pi does not implement Pi lifecycle hook orchestration

[frontendwizard]

Summary

@a5c-ai/babysitter-pi@0.1.3 appears to be a thin command-forwarding package only. It registers slash-command aliases, but does not implement Pi lifecycle hook/event integration for automatic orchestration.

Evidence

• @a5c-ai/babysitter-pi/extensions/index.ts only calls pi.registerCommand(...) and forwards to /skill:<name>.
• No pi.on("agent_end"), pi.on("session_start"), pi.on("turn_end"), or equivalent loop-driving hook exists in the package.
• babysitter harness:discover --json reports Pi capabilities as:
  • programmatic
  • session-binding
  • headless-prompt
• It does not report stop-hook for Pi, while Claude/Codex/Cursor do.
• The Pi package README says the extension is intentionally thin and “does not implement a custom loop driver”.
• The doctor skill checks Claude-style hook files (hooks/babysitter-stop-hook.sh, hooks.json), which do not exist in the Pi package. That makes doctor report hook failures even though Pi runs can complete via in-turn npx orchestration.

Expected

For Pi, babysitter should support local hook/event orchestration through Pi extension lifecycle events, likely:

• session_start for session binding/resume metadata
• agent_end or turn_end for continuing pending runs after assistant turns
• possibly tool_call / tool_result for task/effect integration or safety gates

harness:discover should advertise the appropriate Pi hook capability once implemented.

Actual

Pi runs work only when the skill manually drives the orchestration loop in-turn. There is no installed local Pi hook integration to continue runs automatically.

Suggested fix

Implement a real babysitter-pi extension hook layer that:

1. Binds Pi session identity to babysitter runs.
2. Detects active runs for the current session/project.
3. On agent_end/turn_end, calls the SDK loop/stop-hook equivalent.
4. Avoids infinite loops/runaway iteration.
5. Updates doctor to check Pi extension event hooks instead of Claude hook files when harness is Pi.

[a5c-ai]

Triage Summary

Issue is still valid but partially addressed on staging. Pi now has session_start binding, but it still lacks agent_end / turn_end continuation, does not advertise stop-hook support, and the generated npm package omits hooks/ from packed files even though the extension calls hook bridge scripts.

Critical Evaluation

The original report is now partially stale: session_start is implemented in staging. The core orchestration gap remains: no Pi end-of-turn lifecycle handler drives pending Babysitter runs after assistant turns.

Root Cause Analysis

Evidence from current staging (7ee1a2de6d525b144c6923aa932753cb474e8683):

• plugins/babysitter-unified/per-harness/pi/extensions-index.ts:32-40 sets PI_SESSION_ID, BABYSITTER_SESSION_ID, and PI_PLUGIN_ROOT.
• plugins/babysitter-unified/per-harness/pi/extensions-index.ts:43-49 builds session_start hook input.
• plugins/babysitter-unified/per-harness/pi/extensions-index.ts:81-82 registers pi.on("session_start", ...) and calls babysitter-proxied-session-start.js.
• artifacts/generated-plugins/pi/extensions/index.ts:81-82 contains the same generated session_start registration.
• Searches over source and generated package found no pi.on("agent_end") or pi.on("turn_end") registration.
• packages/babysitter-sdk/src/harness/adapters/pi.ts:25-30 declares only Programmatic, SessionBinding, and HeadlessPrompt, with hookDriven: false and noHookSupport: true.
• packages/atlas/graph/extensions/plugin-artifacts/plugin-target-pi.yaml:42-59 likewise lists only Programmatic, SessionBinding, and HeadlessPrompt, with hookDriven: false.
• artifacts/generated-plugins/pi/package.json:33-43 omits hooks/ from the package files list. npm pack --dry-run --json ./artifacts/generated-plugins/pi confirmed no hooks/* files are packed.
• babysitter harness:discover --json could not report Pi capabilities on staging because the command now returns DeprecatedCommand; based on adapter/catalog metadata above, Pi still does not advertise stop-hook.

Affected Components

Packages/components: @a5c-ai/babysitter-pi, SDK harness adapter, atlas plugin target metadata, generated plugin packaging.

Effort: effort:medium.

Recommended Approach

1. Keep session_start, but add a Pi lifecycle continuation handler for the real supported end-of-turn event (agent_end or turn_end).
2. Route that handler through the same bounded continuation/backoff model used by other lifecycle integrations.
3. Update capability metadata without falsely labeling Pi as stop-hook if the actual primitive is async lifecycle continuation.
4. Add hooks/ to the generated package files list or otherwise ensure called hook bridges are included in the published package.
5. Add generated-package tests that assert the Pi extension registers the expected lifecycle events and that npm pack --dry-run includes required hook bridge files.

Priority

priority:medium, risk:medium. This affects Pi orchestration ergonomics and automatic continuation, but in-turn babysit / yolo orchestration remains a workaround.

[a5c-ai]

Triage Summary

Pi lifecycle orchestration is partially addressed on staging, but the issue is still valid: session_start now exists, while turn-boundary auto-continuation via agent_end/turn_end is still missing and the generated npm package currently omits generated hook scripts.

Critical Evaluation

The original report is no longer fully accurate where it says the Pi package is only thin command forwarding. Staging now has a session_start listener in plugins/babysitter-unified/per-harness/pi/extensions-index.ts:81-83, and it forwards to babysitter-proxied-session-start.js.

The core bug remains: there is no pi.on("agent_end") or pi.on("turn_end") in plugins/babysitter-unified/per-harness/pi/extensions-index.ts, so Pi still has no local lifecycle event that drives the Babysitter stop/iteration loop after assistant turns.

Root Cause Analysis

Evidence from staging:

• plugins/babysitter-unified/per-harness/pi/extensions-index.ts:32-40 syncs PI_SESSION_ID, BABYSITTER_SESSION_ID, and PI_PLUGIN_ROOT.
• plugins/babysitter-unified/per-harness/pi/extensions-index.ts:43-50 builds a session_start hook payload.
• plugins/babysitter-unified/per-harness/pi/extensions-index.ts:81-83 registers only pi.on("session_start") and runs babysitter-proxied-session-start.js.
• packages/babysitter-sdk/src/harness/adapters/pi.ts:25-29 still declares Pi capabilities as Programmatic, SessionBinding, HeadlessPrompt, with loopControlTerm: "skill-driven", hookDriven: false, and noHookSupport: true.
• packages/babysitter-sdk/src/harness/__tests__/discovery.test.ts:328-331 explicitly asserts Pi does not contain stop-hook.
• packages/adapters/extensions/src/targets/adapters/pi.ts:101-111 generates package.json#files without hooks/.

I generated the current Pi package from staging into /tmp with:

npx --yes --package=tsx tsx packages/adapters/extensions/src/cli.ts compile --target pi --source plugins/babysitter-unified --output /tmp/generated-pi-948.q4Tt2U --verbose --verify

Generated package evidence:

• /tmp/generated-pi-948.q4Tt2U/extensions/index.ts:81-83 has the same session_start listener.
• /tmp/generated-pi-948.q4Tt2U/hooks/babysitter-proxied-stop.js:11-20 exists in the generated directory and would proxy to hooks/stop.sh.
• /tmp/generated-pi-948.q4Tt2U/package.json:33-42 omits hooks/ from published files.
• npm pack /tmp/generated-pi-948.q4Tt2U confirmed the tarball has no package/hooks/* entries.

babysitter harness:discover --json could not be used for capability output in the current staging CLI because it exits with DeprecatedCommand and points to genty. Static staging metadata and tests therefore remain the best available capability evidence, and they still show no Pi stop-hook capability.

Affected Components

• Packages: @a5c-ai/babysitter-pi, @a5c-ai/babysitter-sdk, @a5c-ai/extensions-adapter, @a5c-ai/hooks-adapter-pi
• Labels: bug, hooks-mux, plugins, plugin-pi, effort:medium

Recommended Approach

1. Wire a Pi turn-boundary lifecycle event (agent_end if supported by Pi, otherwise turn_end or the correct Pi-native equivalent) to the Babysitter stop/iteration hook.
2. Decide whether Pi should advertise stop-hook or a distinct programmatic loop-driver capability. Do not update discovery metadata until the shipped package actually invokes the lifecycle hook.
3. Fix generated package publishing so required hook scripts are included, likely by adding hooks/ to packages/adapters/extensions/src/targets/adapters/pi.ts:101-111 if those scripts remain the runtime path.
4. Add tests that compile the Pi package, run npm pack, and assert both extension event wiring and required hook files are present in the tarball.
5. Update doctor separately if Pi needs diagnostics that are not Claude-style stop-hook checks.

Priority

priority:medium, risk:medium. Workflows are affected because Pi still cannot auto-continue runs after turns, but users can still drive runs manually/in-turn through skills.

Risk Analysis

• A synchronous agent_end/turn_end handler could block Pi turns or create runaway iteration loops. Mitigate with bounded async/fire-and-forget execution, active-run detection, backoff, and loop guards.
• Capability metadata could become misleading if updated before the package ships usable hook scripts. Mitigate with package/tarball tests before advertising capability.
• Pi doctor checks may need to diverge from Claude stop-hook checks. Mitigate with Pi-specific doctor coverage after runtime behavior is finalized.

Ready for development.