test(settings): cover settings fallback defaults

Author: nigeldelviero

webview-ui/src/components/settings/__tests__/SettingsView.spec.tsx

@@ -1,10 +1,11 @@
 // pnpm --filter @roo-code/vscode-webview test src/components/settings/__tests__/SettingsView.spec.tsx
 
-import { render, screen, fireEvent, within } from "@/utils/test-utils"
+import { render, screen, fireEvent, within, waitFor } from "@/utils/test-utils"
 import { QueryClient, QueryClientProvider } from "@tanstack/react-query"
 
 import { vscode } from "@/utils/vscode"
 import { ExtensionStateContextProvider } from "@/context/ExtensionStateContext"
+import { DEFAULT_CHECKPOINT_TIMEOUT_SECONDS } from "@roo-code/types"
 
 import SettingsView from "../SettingsView"
 
@@ -287,7 +288,7 @@ const mockPostMessage = (state: any) => {
 	)
 }
 
-const renderSettingsView = () => {
+const renderSettingsView = (initialState: any = {}) => {
 	const onDone = vi.fn()
 	const queryClient = new QueryClient()
 
@@ -300,7 +301,7 @@ const renderSettingsView = () => {
 	)
 
 	// Hydrate initial state.
-	mockPostMessage({})
+	mockPostMessage(initialState)
 
 	// Helper function to activate a tab and ensure its content is visible
 	const activateTab = (tabId: string) => {
@@ -443,6 +444,29 @@ describe("SettingsView - Sound Settings", () => {
 		)
 	})
 
+	it("saves fallback defaults for checkpoint and terminal settings", async () => {
+		renderSettingsView({
+			enableCheckpoints: undefined,
+			checkpointTimeout: undefined,
+			terminalShellIntegrationTimeout: undefined,
+			settingsImportedAt: new Date().toISOString(),
+		})
+
+		await waitFor(() => expect(screen.getByTestId("save-button")).toBeInTheDocument())
+		fireEvent.click(screen.getByTestId("save-button"))
+
+		expect(vscode.postMessage).toHaveBeenCalledWith(
+			expect.objectContaining({
+				type: "updateSettings",
+				updatedSettings: expect.objectContaining({
+					enableCheckpoints: false,
+					checkpointTimeout: DEFAULT_CHECKPOINT_TIMEOUT_SECONDS,
+					terminalShellIntegrationTimeout: 30_000,
+				}),
+			}),
+		)
+	})
+
 	it("shows tts slider when sound is enabled", () => {
 		// Render once and get the activateTab helper
 		const { activateTab, getSettingsContent } = renderSettingsView()