fix(eslint): migrate provider literals and shared rule tests

Author: WebMad

packages/config-eslint/provider-identifiers.test.js

@@ -4,10 +4,16 @@ import { createProviderIdentifierConfig } from "./provider-identifiers.js"
 
 const config = createProviderIdentifierConfig({
 	providerIdentifiers: {
+		anthropic: "anthropic",
+		openaiNative: "openai-native",
 		openrouter: "openrouter",
+		poe: "poe",
 		vercelAiGateway: "vercel-ai-gateway",
 	},
-	retiredProviderIdentifiers: {},
+	retiredProviderIdentifiers: {
+		groq: "groq",
+		roo: "roo",
+	},
 })
 const rule = config.plugins.zoo.rules["no-raw-provider-identifiers"]
 
@@ -40,3 +46,59 @@ ruleTester.run("no-raw-provider-identifiers provider map keys", rule, {
 		},
 	],
 })
+
+ruleTester.run("no-raw-provider-identifiers provider-like values", rule, {
+	valid: [
+		"const apiProvider = retiredProviderIdentifiers.roo",
+		"const provider = retiredProviderIdentifiers.groq",
+		'const config = { apiProvider: "external-provider" }',
+		"const config = { apiProvider: providerIdentifiers.poe }",
+		'const response = { protocol: "anthropic", format: "openrouter" }',
+	],
+	invalid: [
+		{
+			code: 'const apiProvider = "roo"',
+			errors: [
+				{
+					messageId: "useCanonical",
+					data: { replacement: "retiredProviderIdentifiers.roo", value: "roo" },
+					type: "Literal",
+				},
+			],
+		},
+		{
+			code: "const persistedProvider = `groq`",
+			errors: [
+				{
+					messageId: "useCanonical",
+					data: { replacement: "retiredProviderIdentifiers.groq", value: "groq" },
+					type: "TemplateLiteral",
+				},
+			],
+		},
+		{
+			code: 'const config = { apiProvider: "poe", imageProvider: `openrouter` }',
+			errors: [
+				{ messageId: "useCanonical", data: { replacement: "providerIdentifiers.poe", value: "poe" } },
+				{
+					messageId: "useCanonical",
+					data: { replacement: "providerIdentifiers.openrouter", value: "openrouter" },
+				},
+			],
+		},
+		{
+			code: 'config["apiProvider"] = "poe"; if (imageProvider === "openrouter") {}',
+			errors: [
+				{ messageId: "useCanonical", data: { replacement: "providerIdentifiers.poe", value: "poe" } },
+				{
+					messageId: "useCanonical",
+					data: { replacement: "providerIdentifiers.openrouter", value: "openrouter" },
+				},
+			],
+		},
+		{
+			code: 'switch (config.apiProvider) { case "poe": break; case providerIdentifiers.openrouter: break }',
+			errors: [{ messageId: "useCanonical", data: { replacement: "providerIdentifiers.poe", value: "poe" } }],
+		},
+	],
+})

packages/types/src/__tests__/kimi-code.test.ts

@@ -1,3 +1,4 @@
+import { providerIdentifiers } from "../provider-identifiers.js"
 import {
 	SECRET_STATE_KEYS,
 	dynamicProviders,
@@ -16,13 +17,15 @@ describe("Kimi Code provider types", () => {
 	it("parses OAuth and API-key settings independently from Moonshot", () => {
 		expect(
 			providerSettingsSchemaDiscriminated.parse({
-				apiProvider: "kimi-code",
+				apiProvider: providerIdentifiers.kimiCode,
 				kimiCodeAuthMethod: "api-key",
 				kimiCodeApiKey: "kimi-key",
 				apiModelId: kimiCodeDefaultModelId,
 			}),
 		).toMatchObject({ kimiCodeApiKey: "kimi-key" })
-		expect(providerSettingsSchema.parse({ apiProvider: "kimi-code", kimiCodeAuthMethod: "oauth" })).toMatchObject({
+		expect(
+			providerSettingsSchema.parse({ apiProvider: providerIdentifiers.kimiCode, kimiCodeAuthMethod: "oauth" }),
+		).toMatchObject({
 			kimiCodeAuthMethod: "oauth",
 		})
 	})

packages/types/src/__tests__/provider-model-id.test.ts

@@ -1,3 +1,4 @@
+import { retiredProviderIdentifiers } from "../provider-identifiers.js"
 import { getModelId, modelIdKeys, providerIdentifiers, type ProviderSettings } from "../index.js"
 
 const expectedModelIdKeys = [
@@ -75,7 +76,7 @@ describe("getModelId", () => {
 
 	it("preserves legacy model ID precedence for retired providers", () => {
 		const settings: ProviderSettings = {
-			apiProvider: "groq",
+			apiProvider: retiredProviderIdentifiers.groq,
 			lmStudioDraftModelId: "draft-model",
 			requestyModelId: "requesty-model",
 		}

packages/types/src/__tests__/telemetry.test.ts

@@ -1,3 +1,4 @@
+import { providerIdentifiers } from "../provider-identifiers.js"
 // pnpm --filter @roo-code/types test src/__tests__/telemetry.test.ts
 
 import {
@@ -536,7 +537,7 @@ describe("telemetry error utilities", () => {
 				consecutiveMistakeCount: 5,
 				consecutiveMistakeLimit: 3,
 				reason: "no_tools_used",
-				provider: "anthropic",
+				provider: providerIdentifiers.anthropic,
 				modelId: "claude-3-sonnet-20240229",
 			})
 		})

packages/types/src/image-generation.ts

@@ -1,3 +1,5 @@
+import { providerIdentifiers } from "./provider-identifiers.js"
+
 /**
  * Image generation model constants
  */
@@ -16,12 +18,28 @@ export interface ImageGenerationModel {
 
 export const IMAGE_GENERATION_MODELS: ImageGenerationModel[] = [
 	// OpenRouter models
-	{ value: "google/gemini-2.5-flash-image", label: "Gemini 2.5 Flash Image", provider: "openrouter" },
-	{ value: "google/gemini-3-pro-image-preview", label: "Gemini 3 Pro Image Preview", provider: "openrouter" },
-	{ value: "openai/gpt-5-image", label: "GPT-5 Image", provider: "openrouter" },
-	{ value: "openai/gpt-5-image-mini", label: "GPT-5 Image Mini", provider: "openrouter" },
-	{ value: "black-forest-labs/flux.2-flex", label: "Black Forest Labs FLUX.2 Flex", provider: "openrouter" },
-	{ value: "black-forest-labs/flux.2-pro", label: "Black Forest Labs FLUX.2 Pro", provider: "openrouter" },
+	{
+		value: "google/gemini-2.5-flash-image",
+		label: "Gemini 2.5 Flash Image",
+		provider: providerIdentifiers.openrouter,
+	},
+	{
+		value: "google/gemini-3-pro-image-preview",
+		label: "Gemini 3 Pro Image Preview",
+		provider: providerIdentifiers.openrouter,
+	},
+	{ value: "openai/gpt-5-image", label: "GPT-5 Image", provider: providerIdentifiers.openrouter },
+	{ value: "openai/gpt-5-image-mini", label: "GPT-5 Image Mini", provider: providerIdentifiers.openrouter },
+	{
+		value: "black-forest-labs/flux.2-flex",
+		label: "Black Forest Labs FLUX.2 Flex",
+		provider: providerIdentifiers.openrouter,
+	},
+	{
+		value: "black-forest-labs/flux.2-pro",
+		label: "Black Forest Labs FLUX.2 Pro",
+		provider: providerIdentifiers.openrouter,
+	},
 ]
 
 /**

pnpm-lock.yaml

@@ -529,7 +529,6 @@
 	},
 	"devDependencies": {
 		"@ai-sdk/openai-compatible": "2.0.56",
-		"@typescript-eslint/parser": "8.32.1",
 		"@roo-code/build": "workspace:^",
 		"@roo-code/config-eslint": "workspace:^",
 		"@roo-code/config-typescript": "workspace:^",