test(e2e): ignore partial asks in completion waits (#1449)

Co-authored-by: Roomote <roomote@roomote.dev>

Author: zoomote[bot]

apps/vscode-e2e/AGENTS.md

@@ -158,6 +158,10 @@ Background API calls from the extension (usage collection, initialization) hit a
 | `OPENROUTER_API_KEY=<key> pnpm --filter @roo-code/vscode-e2e test:record` | Record mode — proxies to real API, writes `openai-*.json`          |
 | `OPENROUTER_API_KEY=<key> pnpm --filter @roo-code/vscode-e2e test:ci`     | Real-API mode — runs against live OpenRouter (for drift detection) |
 
+## Waiting for actionable messages
+
+Tool and completion asks can be emitted first as partial streaming previews. Tests that approve an ask, navigate away, or assert a durable action must wait for `message.partial !== true`; observing a matching tool name is not sufficient. Use `isCompletedAsk` from `src/suite/utils.ts` for completion-oriented message collectors. Only consume partial asks when the test explicitly covers streaming behavior.
+
 ## Tests that use a fetch interceptor instead of aimock
 
 Some suites can't redirect their provider through aimock. These suites patch `globalThis.fetch` directly — the OpenAI SDK resolves `fetch` at API client construction time (which happens lazily at task start), so installing the interceptor before `api.startNewTask()` is sufficient. Installing it before `api.setConfiguration()` (as done below) is the conservative, recommended order.

apps/vscode-e2e/src/suite/index.ts

@@ -5,7 +5,7 @@ import * as vscode from "vscode"
 
 import { RooCodeEventName, type RooCodeAPI } from "@roo-code/types"
 
-import { waitFor } from "./utils"
+import { isCompletedAsk, waitFor } from "./utils"
 
 export async function run() {
 	const extension = vscode.extensions.getExtension<RooCodeAPI>("ZooCodeOrganization.zoo-code")
@@ -34,7 +34,7 @@ export async function run() {
 	// Automatically approve completion_result asks so tests don't stall waiting
 	// for a button that the webview routes to "start new task" rather than "yes".
 	api.on(RooCodeEventName.Message, ({ message }) => {
-		if (message.type === "ask" && message.ask === "completion_result") {
+		if (isCompletedAsk(message) && message.ask === "completion_result") {
 			void api.approveCurrentAsk().catch((error) => {
 				console.error("Failed to approve completion result", error)
 			})

apps/vscode-e2e/src/suite/subtasks.test.ts

@@ -3,7 +3,7 @@ import * as assert from "assert"
 import { RooCodeEventName, type ClineMessage } from "@roo-code/types"
 
 import { setDefaultSuiteTimeout } from "./test-utils"
-import { sleep, waitFor, waitUntilCompleted } from "./utils"
+import { isCompletedAsk, sleep, waitFor, waitUntilCompleted } from "./utils"
 import {
 	SCHED_COMPLETED_PROMPT,
 	SCHED_COMPLETED_RESULT,
@@ -180,7 +180,7 @@ suite("Roo Code Subtasks", function () {
 		const asks: Record<string, ClineMessage[]> = {}
 
 		const messageHandler = ({ taskId, message }: { taskId: string; message: ClineMessage }) => {
-			if (message.type === "ask") {
+			if (isCompletedAsk(message)) {
 				asks[taskId] = asks[taskId] || []
 				asks[taskId].push(message)
 			}
@@ -266,7 +266,7 @@ suite("Roo Code Subtasks", function () {
 		const says: Record<string, ClineMessage[]> = {}
 
 		const messageHandler = ({ taskId, message }: { taskId: string; message: ClineMessage }) => {
-			if (message.type === "ask") {
+			if (isCompletedAsk(message)) {
 				asks[taskId] = asks[taskId] || []
 				asks[taskId].push(message)
 			}
@@ -347,7 +347,7 @@ suite("Roo Code Subtasks", function () {
 		let delegationCompletedSummary: string | undefined
 
 		const messageHandler = ({ taskId, message }: { taskId: string; message: ClineMessage }) => {
-			if (message.type === "ask") {
+			if (isCompletedAsk(message)) {
 				asks[taskId] = asks[taskId] || []
 				asks[taskId].push(message)
 			}
@@ -452,7 +452,7 @@ suite("Roo Code Subtasks", function () {
 		const messages: Record<string, ClineMessage[]> = {}
 
 		const messageHandler = ({ taskId, message }: { taskId: string; message: ClineMessage }) => {
-			if (message.type === "ask") {
+			if (isCompletedAsk(message)) {
 				asks[taskId] = asks[taskId] || []
 				asks[taskId].push(message)
 			}
@@ -532,7 +532,7 @@ suite("Roo Code Subtasks", function () {
 		const says: Record<string, ClineMessage[]> = {}
 
 		const messageHandler = ({ taskId, message }: { taskId: string; message: ClineMessage }) => {
-			if (message.type === "ask") {
+			if (isCompletedAsk(message)) {
 				asks[taskId] = asks[taskId] || []
 				asks[taskId].push(message)
 			}
@@ -615,7 +615,7 @@ suite("Roo Code Subtasks", function () {
 		let delayedChildRequestStartedAt: number | undefined
 
 		const messageHandler = ({ taskId, message }: { taskId: string; message: ClineMessage }) => {
-			if (message.type === "ask") {
+			if (isCompletedAsk(message)) {
 				asks[taskId] = asks[taskId] || []
 				asks[taskId].push(message)
 			}
@@ -842,7 +842,7 @@ suite("Roo Code Subtasks", function () {
 		const says: Record<string, ClineMessage[]> = {}
 
 		const messageHandler = ({ taskId, message }: { taskId: string; message: ClineMessage }) => {
-			if (message.type === "ask") {
+			if (isCompletedAsk(message)) {
 				asks[taskId] = asks[taskId] || []
 				asks[taskId].push(message)
 			}
@@ -940,7 +940,7 @@ suite("Roo Code Subtasks", function () {
 		const says: Record<string, ClineMessage[]> = {}
 
 		const messageHandler = ({ taskId, message }: { taskId: string; message: ClineMessage }) => {
-			if (message.type === "ask") {
+			if (isCompletedAsk(message)) {
 				asks[taskId] = asks[taskId] || []
 				asks[taskId].push(message)
 			}
@@ -1101,7 +1101,7 @@ suite("Roo Code Subtasks", function () {
 		const says: Record<string, ClineMessage[]> = {}
 
 		const messageHandler = ({ taskId, message }: { taskId: string; message: ClineMessage }) => {
-			if (message.type === "ask") {
+			if (isCompletedAsk(message)) {
 				asks[taskId] = asks[taskId] || []
 				asks[taskId].push(message)
 			}
@@ -1157,7 +1157,7 @@ suite("Roo Code Subtasks", function () {
 		const says: Record<string, ClineMessage[]> = {}
 
 		const messageHandler = ({ taskId, message }: { taskId: string; message: ClineMessage }) => {
-			if (message.type === "ask") {
+			if (isCompletedAsk(message)) {
 				asks[taskId] = asks[taskId] || []
 				asks[taskId].push(message)
 			}

apps/vscode-e2e/src/suite/tools/write-to-file.test.ts

@@ -5,7 +5,7 @@ import * as vscode from "vscode"
 
 import { RooCodeEventName, type ClineMessage } from "@roo-code/types"
 
-import { waitUntilCompleted, sleep } from "../utils"
+import { isCompletedAsk, waitUntilCompleted, sleep } from "../utils"
 import { setDefaultSuiteTimeout } from "../test-utils"
 
 const TEST_DIR_NAME = "write-to-file-tool-fixture"
@@ -120,7 +120,7 @@ suite("Roo Code write_to_file Tool", function () {
 
 			const toolApprovalMessage = messages.find(
 				(message) =>
-					message.type === "ask" &&
+					isCompletedAsk(message) &&
 					message.ask === "tool" &&
 					message.text?.includes("write-to-file-smoke.txt"),
 			)
@@ -168,7 +168,7 @@ suite("Roo Code write_to_file Tool", function () {
 
 			const toolApprovalMessage = messages.find(
 				(message) =>
-					message.type === "ask" &&
+					isCompletedAsk(message) &&
 					message.ask === "tool" &&
 					message.text?.includes("write-to-file-nested-smoke.txt"),
 			)

apps/vscode-e2e/src/suite/utils.test.ts

@@ -0,0 +1,16 @@
+import * as assert from "assert"
+
+import type { ClineMessage } from "@roo-code/types"
+
+import { isCompletedAsk } from "./utils"
+
+suite("E2E message guards", () => {
+	test("distinguishes completed asks from streaming previews", () => {
+		const message = { ts: 1, type: "ask", ask: "tool" } satisfies ClineMessage
+
+		assert.strictEqual(isCompletedAsk({ ...message, partial: true }), false)
+		assert.strictEqual(isCompletedAsk({ ...message, partial: false }), true)
+		assert.strictEqual(isCompletedAsk(message), true)
+		assert.strictEqual(isCompletedAsk({ ts: 1, type: "say", say: "text" }), false)
+	})
+})

apps/vscode-e2e/src/suite/utils.ts

@@ -1,4 +1,6 @@
-import { RooCodeEventName, type RooCodeAPI } from "@roo-code/types"
+import { RooCodeEventName, type ClineMessage, type RooCodeAPI } from "@roo-code/types"
+
+export const isCompletedAsk = (message: ClineMessage) => message.type === "ask" && message.partial !== true
 
 type WaitForOptions = {
 	timeout?: number

apps/vscode-e2e/src/visual/sceneController.ts

@@ -4,6 +4,8 @@ import * as vscode from "vscode"
 
 import { RooCodeEventName, type ClineMessage, type RooCodeTestAPI, type WebviewThemeFixture } from "@roo-code/types"
 
+import { isCompletedAsk } from "../suite/utils"
+
 const POLL_INTERVAL_MS = 100
 const SCENE_TIMEOUT_MS = 60_000
 
@@ -103,7 +105,7 @@ export async function run(): Promise<void> {
 				)
 				if (
 					(message.type === "say" && message.say === "completion_result" && message.text?.includes(result)) ||
-					(message.type === "ask" && message.ask === "completion_result" && message.text?.includes(result))
+					(isCompletedAsk(message) && message.ask === "completion_result" && message.text?.includes(result))
 				) {
 					resolve()
 				}