From 1b568bcaa802276ac65f8e55f52de01da2f78b3b Mon Sep 17 00:00:00 2001 From: emmanuelm41 Date: Wed, 3 Jun 2026 10:22:55 -0300 Subject: [PATCH] fix(release-rust): install zip for Windows-msvc packaging + cap build timeout MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The cargo-xwin build of `-pc-windows-msvc` succeeds on Linux, but the Package step then fails with `zip: command not found` — Windows artifacts are zipped and the Linux build host has no `zip` by default. Add `zip` to the xwin toolchain install step. Also add `timeout-minutes: 45` to the build job so a stalled cargo-xwin CRT/SDK download fails fast instead of running to GitHub's 6h default. (Observed ~16min CRT downloads on some self-hosted runners with slow egress to Microsoft's CDN.) --- .github/workflows/_release-rust.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/_release-rust.yml b/.github/workflows/_release-rust.yml index 175be60..9a614b6 100644 --- a/.github/workflows/_release-rust.yml +++ b/.github/workflows/_release-rust.yml @@ -135,6 +135,9 @@ jobs: name: Build ${{ matrix.target }} needs: setup runs-on: ${{ matrix.runner }} + # Cap a single target's build so a hang (e.g. a stalled cargo-xwin CRT/SDK + # download) fails fast instead of running to GitHub's 6h default. + timeout-minutes: 45 strategy: fail-fast: false matrix: ${{ fromJSON(needs.setup.outputs.matrix) }} @@ -192,13 +195,15 @@ jobs: # lld-link against the MSVC CRT + Windows SDK that `xwin` downloads, using # clang/clang-cl as the C/C++ compiler. nasm + cmake are needed by native # deps (aws-lc-sys, ring) whose build scripts assemble/cmake C for the - # target. Runs on the Linux build host (only reached when use_xwin=true). + # target. `zip` is needed by the Package step (Windows artifacts are .zip, + # and the Linux host has no `zip` by default). Runs on the Linux build host + # (only reached when use_xwin=true). - name: Install xwin toolchain (Windows-msvc cross) if: matrix.use_xwin run: | sudo apt-get update sudo apt-get install -y --no-install-recommends \ - clang lld llvm nasm cmake + clang lld llvm nasm cmake zip - name: Install cargo-xwin if: matrix.use_xwin uses: taiki-e/install-action@v2