-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi language support #693
Comments
yes, can you please create a PR? |
Sorry, I have been busy with exams lately. I will try to submit a PR by the end of March |
many thanks, take the time you need |
see #731 |
Do we need to continue adding multilingual support to the current version? |
If you want you can open a PR anytime, but I don't think it will have a long time of usage |
Hello, I think non php version will exist longer then I thought, so if you want your can open a PR. Or if you give me the permission I can try to merge the language related changes from your fork into NPMplus |
it seems only json files, cache.json and i18n.js are changed in your fork, correct? |
yes |
language is read from browser in your fork? since I don't see that you added a selection box, correct? |
lateautumn233@d1aba3a#diff-15ad3fa19f477ab316a0d14f11afb2d1181e011f30500905e47013bd4891bcb4R5 |
so this patch file is enough? https://github.com/NginxProxyManager/nginx-proxy-manager/commit/d1aba3aaaa82f1319a8db06e4023ad2c4f0ea6c8.patch and then I can place every language in i18n/<lang-code>/messages.json |
I applied your patch (but also modified it), if you want to add your language see this commit as template: a026b42 |
I have a branch of nginx proxy manager with added support for multiple languages
Perhaps we can also add multilingual support for npmplus?
https://github.com/lateautumn233/nginx-proxy-manager/commits/weblate-nginxproxymanager-nginxproxymanager/
thanks
The text was updated successfully, but these errors were encountered: