Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi language support #693

Open
lateautumn233 opened this issue Mar 10, 2024 · 13 comments
Open

Multi language support #693

lateautumn233 opened this issue Mar 10, 2024 · 13 comments
Assignees

Comments

@lateautumn233
Copy link

I have a branch of nginx proxy manager with added support for multiple languages
Perhaps we can also add multilingual support for npmplus?

https://github.com/lateautumn233/nginx-proxy-manager/commits/weblate-nginxproxymanager-nginxproxymanager/

thanks

@Zoey2936
Copy link
Member

yes, can you please create a PR?

@lateautumn233
Copy link
Author

Sorry, I have been busy with exams lately. I will try to submit a PR by the end of March

@Zoey2936
Copy link
Member

many thanks, take the time you need

@Zoey2936
Copy link
Member

see #731

@Zoey2936 Zoey2936 self-assigned this Mar 31, 2024
@lateautumn233
Copy link
Author

Do we need to continue adding multilingual support to the current version?

@Zoey2936
Copy link
Member

If you want you can open a PR anytime, but I don't think it will have a long time of usage

@Zoey2936
Copy link
Member

Hello, I think non php version will exist longer then I thought, so if you want your can open a PR. Or if you give me the permission I can try to merge the language related changes from your fork into NPMplus

@Zoey2936
Copy link
Member

it seems only json files, cache.json and i18n.js are changed in your fork, correct?

@lateautumn233
Copy link
Author

it seems only json files, cache.json and i18n.js are changed in your fork, correct?

yes

@Zoey2936
Copy link
Member

language is read from browser in your fork? since I don't see that you added a selection box, correct?

@lateautumn233
Copy link
Author

language is read from browser in your fork? since I don't see that you added a selection box, correct?

lateautumn233@d1aba3a#diff-15ad3fa19f477ab316a0d14f11afb2d1181e011f30500905e47013bd4891bcb4R5

@Zoey2936
Copy link
Member

Zoey2936 commented Oct 25, 2024

so this patch file is enough? https://github.com/NginxProxyManager/nginx-proxy-manager/commit/d1aba3aaaa82f1319a8db06e4023ad2c4f0ea6c8.patch and then I can place every language in i18n/<lang-code>/messages.json

@Zoey2936
Copy link
Member

I applied your patch (but also modified it), if you want to add your language see this commit as template: a026b42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants