code submission #1 feedback #1
Description
If you have questions about the feedback respond to this issue in GitHub. Grades won't be done until comments are out to everyone, wanted to provide feedback first.
Overall this is a good start. Most of what I saw goes back to variable naming and documentation, with some other items.
Good use of README.md to describe the overall structure and process of the project. If a file is not specified, assume that the process is contained in scripts.py?
Spend a bit of time working on moving toward the type of documentation you had in lab #3.
The model function name is ambiguous and shouldn't need documentation to tell the reader it's writing the model file. write_model or write_model_file would be more useful as names. Similarly, some of your variable names (data, features, points, polygons) could be improved on. As you get further into your work, might there be another set of points that would make that name ambiguous later?
Do you expect the API portion to go smoothly? Working with data from APIs is a valuable skill, but if time gets short consider focusing on the GIS end and working with a data set kept locally.
Your coords_conversion() need to describe what projection you're moving to for x,y. I recall that you're exaggerating z. Documentation would get to this.
As with lab #3, you're using NumPy, but what your use of it so far is easily replaced with range and NumPy excluded entirely. Nice use of a list comprehension.