Fails to render in 2018.1.3f1 or above

[GabLeRoux]

Hey there,
I just came across this project and wanted to give this a try. I haven't found exactly why, but the shader (or how the texture is managed on the plain) seems to fail.

I did not investigate much but I'm noting this here 👍 It's possible it fails on the 2017 versions too.

[GabLeRoux]

For the record, changes to shader files during the import are the following:

diff --git a/Assets/Snowprint/Shaders/SnowGroundShader.shader b/Assets/Snowprint/Shaders/SnowGroundShader.shader
index 6d73cb4..d720cbf 100644
--- a/Assets/Snowprint/Shaders/SnowGroundShader.shader
+++ b/Assets/Snowprint/Shaders/SnowGroundShader.shader
@@ -1,4 +1,6 @@
-<U+FEFF>Shader "Custom/snow_ground"
+<U+FEFF>// Upgrade NOTE: replaced 'mul(UNITY_MATRIX_MVP,*)' with 'UnityObjectToClipPos(*)'
+
+Shader "Custom/snow_ground"
 {
        Properties
        {
@@ -313,7 +315,7 @@
                                for(int i = 0; i < 3; i++)
                                {
                                        //apply model view projection
-                                       o[i].vertex = mul(UNITY_MATRIX_MVP,input[i].vertex);
+                                       o[i].vertex = UnityObjectToClipPos(input[i].vertex);
                                        o[i].uv = input[i].uv;
                                        o[i].detailuv =input[i].detailuv * discardFactor;
                                        o[i].tspace0 = input[i].tspace0;
diff --git a/Assets/Snowprint/Shaders/Sprites-Distance.shader b/Assets/Snowprint/Shaders/Sprites-Distance.shader
index 5cad0e1..d0dbbb3 100644
--- a/Assets/Snowprint/Shaders/Sprites-Distance.shader
+++ b/Assets/Snowprint/Shaders/Sprites-Distance.shader
@@ -1,3 +1,5 @@
+// Upgrade NOTE: replaced 'mul(UNITY_MATRIX_MVP,*)' with 'UnityObjectToClipPos(*)'
+
 Shader "Sprites/Distance"
 {
        Properties
@@ -58,7 +60,7 @@ Shader "Sprites/Distance"
                        v2f vert(appdata_t IN)
                        {
                                v2f OUT;
-                               OUT.vertex = mul(UNITY_MATRIX_MVP, IN.vertex);
+                               OUT.vertex = UnityObjectToClipPos(IN.vertex);
                                OUT.texcoord = IN.texcoord;
                                OUT.color = IN.color;
                                return OUT;

[GabLeRoux]

Oh in fact, this could be due to tesselation shaders not running on mac, or maybe shaders needs some update to support MacOS Metal. I did not work with shaders enough yet, but I've read your post on your website concerning this project and it's awesome :)

[GabLeRoux]

Found in the youtube video's comments:

On MacOS, I'm not running under DirectX, so it makes sense.

[ZGeng]

Hi, thank you. I'm sorry I am recently lacking of time working on this, but I'll look into the issues as soon as I can. I'm not familiar with Metal, but as far as I know, it should also support tessellation.
P.s. this code is written when I was a newbie about Unity and shader programming, it really needs refactor.