Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Use Spring configuration instead of custom variables #19

Open
yogendra opened this issue Jun 19, 2023 · 2 comments
Open
Assignees

Comments

@yogendra
Copy link
Contributor

Currently, documented procedure for supplying database information is node,port, dbname, etc. We can use standard spring attributes instead. You can provide these via program argument, JVM Argument or Environment variables. Here is a quick ref list

Description JVM Arg / Program Arg Environment Var
DB Server Name spring.datasource.hikari.data-source-properties.serverName SPRING_DATASOURCE_HIKARI_DATA_SOURCE_PROPERTIES_SERVERNAME
DB Server Port spring.datasource.hikari.data-source-properties.portNumber SPRING_DATASOURCE_HIKARI_DATA_SOURCE_PROPERTIES_PORT
DB Name spring.datasource.hikari.data-source-properties.databaseName SPRING_DATASOURCE_HIKARI_DATA_SOURCE_PROPERTIES_DATABASENAME
DB User spring.datasource.hikari.username SPRING_DATASOURCE_HIKARI_USERNAME
DB Password spring.datasource.hikari.password SPRING_DATASOURCE_HIKARI_PASSWORD
@akscjo akscjo self-assigned this Jun 21, 2023
@akscjo
Copy link
Collaborator

akscjo commented Jun 27, 2023

@yogendra I created the short variables to ease with the typing the name in the the script. I can replace them with regular environment variables but then it makes it harder to type it in. Most folks(SEs) create the start.sh script and pass the values as -D parameters. Thoughts?

@yogendra
Copy link
Contributor Author

Yeah works that way too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants