Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in get_normalized due to no imputation / return_norm = "no" #101

Open
diyadas opened this issue Dec 8, 2018 · 3 comments
Open

Error in get_normalized due to no imputation / return_norm = "no" #101

diyadas opened this issue Dec 8, 2018 · 3 comments

Comments

@diyadas
Copy link

diyadas commented Dec 8, 2018

The help for get_normalized indicates that

If ‘scone’ was run with ‘return_norm="no"’, this function will
compute the normalized matrix on the fly.

Unfortunately, doesn't seem to work for me because of some error in computing the imputation:

> tmp <- get_normalized(scone_obj, "none,fq,ruv_k=3,no_bio,batch")
Error in x@imputation_fn[[params[1]]](assay(x), impute_args) :
  attempt to apply non-function
> traceback()
3: .local(x, method, ...)
2: get_normalized(scone_obj, "none,fq,ruv_k=3,no_bio,batch")
1: get_normalized(scone_obj, "none,fq,ruv_k=3,no_bio,batch")
> package.version("scone")
[1] "1.4.0"

The issue derives from:

imputed <- x@imputation_fn[[params[1]]](assay(x), impute_args)

as impute_args has been set to NULL by L38.

@mbcole
Copy link
Contributor

mbcole commented Dec 8, 2018

Hey @diyadas - thanks for reporting this! What does scone_obj@imputation_fn look like for this object?

@diyadas
Copy link
Author

diyadas commented Dec 8, 2018

Hi!

> scone_obj@imputation_fn
list()

@mbcole
Copy link
Contributor

mbcole commented Dec 8, 2018

That's interesting because the default is list(none=impute_null). Maybe this was overwritten at some point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants