Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all Fido timeout errors are caught #344

Open
bplotnick opened this issue Jan 17, 2018 · 0 comments · May be fixed by #346
Open

Not all Fido timeout errors are caught #344

bplotnick opened this issue Jan 17, 2018 · 0 comments · May be fixed by #346

Comments

@bplotnick
Copy link
Contributor

There are some twisted errors that occur with low request timeout (the timeout passed in _request_options). The ones i've seen are twisted.internet.error.DNSLookupError and twisted.internet.error.ConnectingCancelledError. These seem like more general errors, but I think they occur because of the fact that the request timeout cancels the twisted deferred.

Either way, if you set the request timeout low, you'll get these, which should be reraised.

The values that I needed to set for timeout to get these errors were:
0.001 (1ms) for twisted.internet.error.ConnectingCancelledError
and
0.0001 (0.1ms) for twisted.internet.error.DNSLookupError - Note: 0 also works

You may ask why anyone in their right mind would set these values so low, but can easily happen when programmatically setting the timeout.

@bplotnick bplotnick linked a pull request Jan 18, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant