Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonschema processing doesn't support jsonschema>=4.0.0 causing bravado to break when working in offline environment #388

Open
HubertJaworski opened this issue Feb 25, 2022 · 2 comments
Open

jsonschema processing doesn't support jsonschema>=4.0.0 causing bravado to break when working in offline environment #388

HubertJaworski opened this issue Feb 25, 2022 · 2 comments

Comments

@HubertJaworski
Copy link

When running an installation on clean python environment, Bravado gets installed with the newest jsonschema, currently >=4.0.0

jsonschema 4.0.0 introduced support for newer draft versions, which does not follow the previous pattern of http://json-schema.org/draft-\d+/schema and with values like http://json-schema.org/draft-2019-09/schema

In bravado_core/model.py:883 your regexp for excluding jsonschema's default schemas should be changed to 'http://json-schema.org/draft-\d+(-\d+)?/schema'

Currently, when using bravado in offline environments, attempting to make request fails and crashes the program
@GuySuday
Copy link

I, too, encountered this problem

@joern-m-h
Copy link

I have the same problem. I opened a PR for it: #389

sjustas pushed a commit to Shoobx/bravado-core that referenced this issue Sep 29, 2022
Filter out schemas introduced in jsonschema 4.0.0+
c43374f 
See Yelp#388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GuySuday @HubertJaworski @joern-m-h