Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Type of rendered component #3

Open
abdelrahmanahmed opened this issue Apr 14, 2020 · 0 comments
Open

Refactor: Type of rendered component #3

abdelrahmanahmed opened this issue Apr 14, 2020 · 0 comments

Comments

@abdelrahmanahmed
Copy link
Contributor

In your App.js i saw that you are rendering a component (image,youtube or link) based on some conditions, i believe it is better to use HOC implement this feature, that is a way cleaner. if you accept this i can do a small PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abdelrahmanahmed