Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will the uCrop support Android 15 16kb page size requirements? #931

Open
Skullper opened this issue Sep 19, 2024 · 4 comments
Open

Will the uCrop support Android 15 16kb page size requirements? #931

Skullper opened this issue Sep 19, 2024 · 4 comments

Comments

@Skullper
Copy link

According to the official documentation https://developer.android.com/guide/practices/page-sizes all native libraries should be recompiled for this change.
The Android 15 was already released to AOSP.
Does the uCrop team have any plans to support these requirements?

@jens-muenker
Copy link

I made a fork which supports 16KB page sizes. In addition to the small updates, I translated most of the code to kotlin.

@efstathiosntonas
Copy link

efstathiosntonas commented Oct 11, 2024

Hi Jens, can you please bring back the onActivityResult?

I’m trying to use your fork with react-native-image-crop-picker and it relies on it.

I know it’s deprecated but I was wondering if you can bring it back and let the devs decide on what to use for activity.

(maybe the react-native-image-crop-picker team use your fork too)

thanks

@jens-muenker
Copy link

Hi @efstathiosntonas, sorry but it has been marked as deprecated for a long time now and I do not want to confuse people by bringing it back. So I am not going to bring it back. I think it will be removed in some of the next Android releases.

Maybe you can ask the react-native-image-crop-picker team to use an ActivityResultLauncher. It should not be that complicated to change. However, I have no experience with using android libraries in react native.

If you need it immediately, you can make a fork of my fork and add the onActivityResult yourself. This is the PR where I removed the code: jens-muenker/uCrop-n-Edit@d33a1d2

@efstathiosntonas
Copy link

@jens-muenker thanks for the update, totally understood. I've forked it and reverted the onActivityResult, works as charm with react-native-crop-picker, thank you for this fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants