Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Android 15 edge-to-edge not supported #913

Open
Ekalips opened this issue Apr 19, 2024 · 3 comments
Open

BUG: Android 15 edge-to-edge not supported #913

Ekalips opened this issue Apr 19, 2024 · 3 comments

Comments

@Ekalips
Copy link

Ekalips commented Apr 19, 2024

With the recently announced change in Android 15 all apps will have to support edge to edge properly. Upon testing how the app behaves when edge-to-edge is on (and nav/status bar colours are set to transparent) I found out that uCrop doesn't actually handle system bar overlays.

I'm attaching a screenshot of control elements and toolbar not being inset correctly.
Screenshot_1713517959

@Ekalips
Copy link
Author

Ekalips commented Apr 19, 2024

Screenshot_1713518091
It's obviously worse with 2-3 button nav

@qeepcologne
Copy link

qeepcologne commented Jul 18, 2024

the top navigation (close and checkmark) is not clickable when build for and running on android 15 (collision with time and network status). Workaround for us is to add back the title, hide the the app name in title and set back the backgrond color.

<activity
            android:name="com.yalantis.ucrop.UCropActivity"
            android:screenOrientation="nosensor"
            android:windowLayoutInDisplayCutoutMode="never"
            android:theme="@style/Ecift.CropTheme"/>

values/style.xml

    <style name="Ecift.CropTheme" parent="Theme.AppCompat.Light.NoActionBar"/>

values-v35/styles.xml

<!-- force add back app bar via title via theme override -->
<style name="Ecift.CropTheme" parent="Theme.AppCompat.Light.NoActionBar">
    <item name="android:windowNoTitle">false</item>
    <item name="android:windowTitleStyle">@style/CropTitleStyle</item>
    <item name="android:windowTitleBackgroundStyle">@style/CropTitleStyleBg</item>
</style>

<!-- hide text in app bar (otherwise app name is shown) -->
<style name="CropTitleStyle">
    <item name="android:textColor">@android:color/transparent</item>
</style>

<!-- set background color of app bar -->
<style name="CropTitleStyleBg">
    <item name="android:background">#8b0000</item>
</style>

@qeepcologne
Copy link

qeepcologne commented Aug 19, 2024

or overwrite in v35/styles.xml

<item name="android:windowOptOutEdgeToEdgeEnforcement">true</item>

until edge-to-edge is supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants