You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Additional context
In general, there are multiple NuGet packages that have updates. The NewtonSoft.Json package in XamlStyler.csproj seems to be the oldest one.
The text was updated successfully, but these errors were encountered:
Unfortunately, there are gotchas with Newtonsoft.Json. Updating can lead to unexpected behavior on older versions of Visual Studio (#377), so we are blocked for now, but going to leave this issue open to track. More information here: Using Newtonsoft.Json in a Visual Studio extension.
Is it really needed to keep releasing new XamlStyler updates for old Visual Studio versions? (not sure how long they need to be supported?)
If it is needed to support them, could that be done from a maintenance branch so that the main branch is not blocked from updating this? I'm not sure about the impact of the vulnerability but keeping a nuget package with a vulnerability in main to support old versions sounds not great to me.
After publishing final feature update supporting VS2017 (#480), we will be unblocked form updating Newtonsoft.Json to version 12.0.2 (#481). Using the two referenced issues to track these changes, so closing this.
Describe the bug
Visual Studio reports vulnerability in nuget reference.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
No vulnerabilities reported
External Configuration
If you are using an external configuration, please attach to help reproduce the issue.
Version Info (please complete the following information):
Additional context
In general, there are multiple NuGet packages that have updates. The NewtonSoft.Json package in XamlStyler.csproj seems to be the oldest one.
The text was updated successfully, but these errors were encountered: