Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio reports vulnerability in nuget reference #465

Closed
hansmbakker opened this issue Jan 25, 2024 · 3 comments
Closed

Visual Studio reports vulnerability in nuget reference #465

hansmbakker opened this issue Jan 25, 2024 · 3 comments
Labels

Comments

@hansmbakker
Copy link

Describe the bug
Visual Studio reports vulnerability in nuget reference.

To Reproduce
Steps to reproduce the behavior:

  1. Checkout the main branch
  2. Open XamlStyler.sln in Visual Studio 2022 17.9
  3. See image

Expected behavior
No vulnerabilities reported

External Configuration
If you are using an external configuration, please attach to help reproduce the issue.

Version Info (please complete the following information):

  • OS: Windows 11
  • Visual Studio: 2022 17.9 Preview 4
  • XAML Styler: main branch (3663f17)

Additional context
In general, there are multiple NuGet packages that have updates. The NewtonSoft.Json package in XamlStyler.csproj seems to be the oldest one.

@grochocki
Copy link
Contributor

Unfortunately, there are gotchas with Newtonsoft.Json. Updating can lead to unexpected behavior on older versions of Visual Studio (#377), so we are blocked for now, but going to leave this issue open to track. More information here: Using Newtonsoft.Json in a Visual Studio extension.

@grochocki grochocki added the VS label Jan 25, 2024
@hansmbakker
Copy link
Author

Is it really needed to keep releasing new XamlStyler updates for old Visual Studio versions? (not sure how long they need to be supported?)

  • If it is needed to support them, could that be done from a maintenance branch so that the main branch is not blocked from updating this? I'm not sure about the impact of the vulnerability but keeping a nuget package with a vulnerability in main to support old versions sounds not great to me.

@grochocki
Copy link
Contributor

After publishing final feature update supporting VS2017 (#480), we will be unblocked form updating Newtonsoft.Json to version 12.0.2 (#481). Using the two referenced issues to track these changes, so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants