Should .editorconfig file be taken into account?

[*.xaml]
end_of_line              = crlf

This is an absolutely crucial feature.

@cyberbot band-aid solution:

Try running it with WSL (install it under Linux first)

Running it from ms-dos should look like this:

wsl /home/<username>/.dotnet/tools/xstyler -p -r -d Wpf -l Minimal

Have you configured git to handle line endings? If not, XAML Styler may not be the only offender, and this could help address it universally. If so, and XAML Styler is messing with line endings, I think we should treat this as a bug. We should not be changing line endings, and instead, if we can detect what they are in the input file, I would suggest we ensure it is preserved in the output.

My project doesn't use git at the moment. So yes, XAML Styler is messing with line endings.

@grochocki .gitattibutes is definitely helpful to ensure that line endings are standardized. It definitely works when a commit is performed. Microsoft recommends having * text eol=lf in certain situations.

There are other issues at play here. Consider a working environment with Windows OS, two IDEs VS and VS Code, as well as WSL.

1. Pre-commit hooks: if one was to run xstyler -p -r -d MyWpf -l Minimal it would output different results under Linux and Windows and there is currently no way to enforce line ending, hence Create EndOfLine option #295. The goal is to fail the commit only for actual bad formatting, not a bad end of line character. .gitattibutes won't get a chance to do its conversion before the pre-commit hooks fails.

2. Switching between VS Code and VS while editing a xaml file would keep changing the line ending. That's because VS Code respects .editorconfig end_of_line setting and XamlStyler doesn't. When it comes to .cs files, both IDEs respect the .editorconfig setting. I could send a PR including that as well.

3. .gitattibutes setting generates annoying warnings every time the .xaml format doesn't match when staging changes.

@grochocki any thoughts on this?

@grochocki, I wanted to introduce XamlStyler to my team's project but it overrides LF to CRLF in every file. Moreover it looks like the xstyler CLI tool adds BOM to the formatted output even if it wasn't there. Look like CFLF and utf-8 settings are hardcoded.

Version control settings could be a band-aid solution to fix the line-ending but my team is using LF on Windows too and we all don't override line-ending neither with git, perforce or other version control. In some cases we need to use both CRLF and LF in the same project and it's a conscious decision to configure it. For example in VS 2019 .editorconfig is the only way to configure line endings.

I agree with @virzak that XamlStyler can benefit a lot with either respecting the .editorconfig or providing it's own config property.