-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate Wigner functions and marginals directly from ABC #419
Comments
BtoPS = Bargmann to Phase Space? |
Does your implementation assume ħ = 2? If I change to e.g. ħ = 1, it doesn't seem to give the correct wigner function. Also, I think something is off in the magnitude, i.e. the W in your implementation has max(W) = 1 import mrmustard.lab_dev as mm
|
Anyway it seems like an easy fix, maybe each representation could have a .wigner(xvec, pvec) and .quadrature(xvec, quadrature_angle) method? With an implementation such that one can call e.g., state.wigner(xvec, pvec) and state.quadrature(xvec, quadrature_angle) for arbitrary states. |
Before posting a feature request
Feature details
Right now Wigner functions and quadrature marginals are calculated in Fock basis (at least in
visualize_2d
), but we should be able to take advantage of the Gaussian nature of the states in Bargmann representation to get a significant speed-up when calculating these things.Implementation
No response
How important would you say this feature is?
2: Somewhat important. Needed this quarter.
Additional information
No response
The text was updated successfully, but these errors were encountered: