Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to loosen the dependency on fuzzywuzzy #58

Open
Agnes-U opened this issue Dec 6, 2022 · 0 comments
Open

Suggest to loosen the dependency on fuzzywuzzy #58

Agnes-U opened this issue Dec 6, 2022 · 0 comments

Comments

@Agnes-U
Copy link

Agnes-U commented Dec 6, 2022

Dear developers,

Your project ultrasonics requires "fuzzywuzzy==0.18.0" in its dependency. After analyzing the source code, we found that the following versions of fuzzywuzzy can also be suitable without affecting your project, i.e., fuzzywuzzy 0.17.0. Therefore, we suggest to loosen the dependency on fuzzywuzzy from "fuzzywuzzy==0.18.0" to "fuzzywuzzy>=0.17.0,<=0.18.0" to avoid any possible conflict for importing more packages or for downstream projects that may use ddos_script.

May I pull a request to further loosen the dependency on fuzzywuzzy?

By the way, could you please tell us whether such dependency analysis may be potentially helpful for maintaining dependencies easier during your development?



Details:

Your project (commit id: 2c31982) directly uses 3 APIs from package fuzzywuzzy.

fuzzywuzzy.fuzz.partial_token_sort_ratio, fuzzywuzzy.fuzz.token_set_ratio, fuzzywuzzy.fuzz.ratio

Beginning fromwhich, 20 functions are then indirectly called, including 16 fuzzywuzzy's internal APIs and 4 outsider APIs as follows:

[/XDGFX/ultrasonics]
+--fuzzywuzzy.fuzz.partial_token_sort_ratio
|      +--fuzzywuzzy.fuzz._token_sort
|      |      +--fuzzywuzzy.fuzz._process_and_sort
|      |      |      +--fuzzywuzzy.utils.full_process
|      |      |      |      +--fuzzywuzzy.utils.asciidammit
|      |      |      |      |      +--fuzzywuzzy.utils.asciionly
|      |      |      |      |      +--fuzzywuzzy.utils.asciidammit
|      |      |      |      +--fuzzywuzzy.string_processing.StringProcessor.replace_non_letters_non_numbers_with_whitespace
|      |      +--fuzzywuzzy.fuzz.partial_ratio
|      |      |      +--fuzzywuzzy.utils.make_type_consistent
|      |      |      +--difflib.SequenceMatcher
|      |      |      +--fuzzywuzzy.StringMatcher.StringMatcher.__init__
|      |      |      |      +--warnings.warn
|      |      |      |      +--fuzzywuzzy.StringMatcher.StringMatcher._reset_cache
|      |      |      +--difflib.SequenceMatcher.get_matching_blocks
|      |      |      +--fuzzywuzzy.StringMatcher.StringMatcher.get_matching_blocks
|      |      |      |      +--fuzzywuzzy.StringMatcher.StringMatcher.get_opcodes
|      |      |      +--difflib.SequenceMatcher.ratio
|      |      |      +--fuzzywuzzy.StringMatcher.StringMatcher.ratio
|      |      |      +--fuzzywuzzy.utils.intr
|      |      +--fuzzywuzzy.fuzz.ratio
|      |      |      +--fuzzywuzzy.utils.make_type_consistent
|      |      |      +--difflib.SequenceMatcher
|      |      |      +--fuzzywuzzy.StringMatcher.StringMatcher.__init__
|      |      |      +--fuzzywuzzy.utils.intr
|      |      |      +--difflib.SequenceMatcher.ratio
|      |      |      +--fuzzywuzzy.StringMatcher.StringMatcher.ratio
+--fuzzywuzzy.fuzz.token_set_ratio
|      +--fuzzywuzzy.fuzz._token_set
|      |      +--fuzzywuzzy.utils.full_process
|      |      +--fuzzywuzzy.utils.validate_string
+--fuzzywuzzy.fuzz.ratio

Since all these functions have not been changed between any version for package "fuzzywuzzy" from [0.17.0] and 0.18.0. Therefore, we believe it is safe to loosen the corresponding dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant