Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle none type #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle none type #62

wants to merge 1 commit into from

Conversation

eldarrarr
Copy link

fixes #46

XDGFX
XDGFX requested changes Dec 11, 2024
View reviewed changes
Copy link
Owner

@XDGFX XDGFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the checks should be for an invalid type, and continue to the next loop iteration if not, so we don't get deep nesting 😁 please change this and I'll merge, I can't as I'm on mobile

ultrasonics/official_plugins/up_spotify.py
name = playlist.get("name")
playlist_id = playlist.get("id")
if name is not None and playlist_id is not None:
item = {"name": name, "id": {"spotify": playlist_id}}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

item should only be added if all the if checks above pass - should be nested within the last check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XDGFX XDGFX XDGFX requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spotify plugin throws "NoneType" object
2 participants
@eldarrarr @XDGFX