-
Notifications
You must be signed in to change notification settings - Fork 372
Type check Emscripten JS overrides and allow changes without php-wasm rebuilds #2891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
At first, I thought we could make our php-wasm JS customizations (i.e., our fcntl() override) more testable by separating them into TS modules that can be examined independently and injected into php-wasm JS at run time. But as I explore these changes, it looks like the most economical way to test our customizations is in their usual context with further integration tests. That said, separating into TS modules would:
So I plan to continue working on this PR, but for the moment, I will pivot to:
|
bec0521 to
e4fbd66
Compare
Motivation for the change, related issues
Our system call overrides are not type checked, and any change to them requires rebuilding php-wasm JS files.
If we can separate our customization into TS modules and inject them into the php-wasm JS, we can benefit from type checking and reduce the number of slow php-wasm rebuilds we perform.
Implementation details
TBD
Testing Instructions (or ideally a Blueprint)