Skip to content

Commit 5c36141

Browse files
committed
Admin reskin: Remove line-height from input fields.
`line-height` values that were previously used to match the height of input fields affect the height of the background shown when text inside those fields is selected. Removing these `line-height` declarations allows the text selection highlight to render more naturally. Additionally, update the height of the custom Date/Time format input fields on the General Settings screen to `32px` to align with the new design system. Reviewed by wildworks, audrasjb. Merges [62171] to the 7.0 branch. Props arkaprabhachowdhury, audrasjb, hmrisad, huzaifaalmesbah, manhar, manishxdp, noruzzaman, ozgursar, r1k0, sachinrajcp123, wildworks. Fixes #64763. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62172 602fd350-edb4-49c9-b593-d223f7449a82
1 parent e53054b commit 5c36141

File tree

7 files changed

+1
-12
lines changed

7 files changed

+1
-12
lines changed

src/wp-admin/css/color-picker.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@
9494
width: 4rem;
9595
font-size: 12px;
9696
font-family: monospace;
97-
line-height: 2.33333333; /* 28px */
9897
margin: 0;
9998
padding: 0 5px;
10099
vertical-align: top;

src/wp-admin/css/common.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1115,7 +1115,6 @@ th.action-links {
11151115

11161116
.wp-filter .search-form input[type="search"] {
11171117
min-height: 32px;
1118-
line-height: 2.14285714; /* 30px for 32px height with 14px font */
11191118
padding: 0 8px;
11201119
}
11211120

src/wp-admin/css/customize-controls.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2184,7 +2184,6 @@ p.customize-section-description {
21842184
}
21852185

21862186
.themes-filter-bar .wp-filter-search {
2187-
line-height: 2.14285714; /* 30px for 32px compact input */
21882187
padding: 0 10px 0 30px;
21892188
max-width: 100%;
21902189
width: 40%;

src/wp-admin/css/dashboard.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,6 @@
533533
width: 40%;
534534
margin: 0;
535535
min-height: 32px;
536-
line-height: 2.14285714;
537536
padding: 0 8px;
538537
}
539538

src/wp-admin/css/forms.css

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ input[type="url"],
6969
input[type="week"] {
7070
padding: 0 12px;
7171
/* inherits font size 14px */
72-
line-height: 2.71428571; /* 38px for 40px min-height */
7372
min-height: 40px;
7473
}
7574

@@ -816,7 +815,6 @@ p.search-box {
816815
p.search-box input[type="search"],
817816
p.search-box input[type="text"] {
818817
min-height: 32px;
819-
line-height: 2.14285714; /* 30px for 32px height with 14px font */
820818
padding: 0 8px;
821819
}
822820

@@ -1237,8 +1235,7 @@ table.form-table td .updated p {
12371235
.options-general-php input.small-text {
12381236
width: 56px;
12391237
margin: -2px 0;
1240-
min-height: 24px;
1241-
line-height: 1.71428571; /* 24px for 14px font size */
1238+
min-height: 32px;
12421239
}
12431240

12441241
.options-general-php .spinner {
@@ -1601,7 +1598,6 @@ table.form-table td .updated p {
16011598
-webkit-appearance: none;
16021599
padding: 0 12px;
16031600
min-height: 40px;
1604-
line-height: 2.5; /* 40px for 16px font */
16051601
}
16061602

16071603
::-webkit-datetime-edit {

src/wp-admin/css/list-tables.css

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -686,7 +686,6 @@ th.sorted a span {
686686
font-size: 13px;
687687
text-align: center;
688688
min-height: 32px;
689-
line-height: 2.30769231; /* 30px for 32px height with 13px font */
690689
padding: 0 8px;
691690
}
692691

@@ -1099,7 +1098,6 @@ tr.inline-edit-row td {
10991098

11001099
.inline-edit-row select,
11011100
.inline-edit-row input:where(:not([type=checkbox],[type=radio],[type=submit],[type=button])) {
1102-
line-height: 2.14285714;
11031101
min-height: 32px;
11041102
padding: 0 8px 0 8px;
11051103
}

src/wp-admin/css/media.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,6 @@ border color while dragging a file over the uploader drop area */
568568

569569
.media-frame.mode-grid .media-toolbar input[type="search"] {
570570
min-height: 32px;
571-
line-height: 2.14285714; /* 30px for 32px height with 14px font */
572571
padding: 0 8px;
573572
}
574573

0 commit comments

Comments
 (0)