Improvements from static analysis

Author: chriszarate

src/wp-includes/collaboration/class-wp-http-polling-sync-server.php

@@ -190,7 +190,7 @@ public function check_permissions( WP_REST_Request $request ) {
 
 			$entity_kind = $type_parts[0];
 			$entity_name = $object_parts[0];
-			$object_id   = isset( $object_parts[1] ) ? (int) $object_parts[1] : null;
+			$object_id   = $object_parts[1] ?? null;
 
 			if ( ! $this->can_user_sync_entity_type( $entity_kind, $entity_name, $object_id ) ) {
 				return new WP_Error(
@@ -411,7 +411,6 @@ private function process_sync_update( string $room, int $client_id, int $cursor,
 				 * All updates are stored persistently.
 				 */
 				return $this->add_update( $room, $client_id, $type, $data );
-				break;
 		}
 
 		return new WP_Error(
@@ -430,7 +429,7 @@ private function process_sync_update( string $room, int $client_id, int $cursor,
 	 * @param int    $client_id Client identifier.
 	 * @param string $type      Update type (sync_step1, sync_step2, update, compaction).
 	 * @param string $data      Base64-encoded update data.
-	 * @return bool|WP_Error True on success, WP_Error on storage failure.
+	 * @return true|WP_Error True on success, WP_Error on storage failure.
 	 */
 	private function add_update( string $room, int $client_id, string $type, string $data ) {
 		$update = array(

src/wp-includes/collaboration/class-wp-sync-post-meta-storage.php

@@ -264,7 +264,7 @@ public function get_update_count( string $room ): int {
 	 *
 	 * @param string $room   Room identifier.
 	 * @param int    $cursor Return updates after this cursor.
-	 * @return array Sync updates.
+	 * @return array<int, mixed> Sync updates.
 	 */
 	public function get_updates_after_cursor( string $room, int $cursor ): array {
 		$all_updates = $this->get_all_updates( $room );

src/wp-includes/collaboration/interface-wp-sync-storage.php

@@ -58,7 +58,7 @@ public function get_update_count( string $room ): int;
 	 *
 	 * @param string $room   Room identifier.
 	 * @param int    $cursor Return updates after this cursor.
-	 * @return array Sync updates.
+	 * @return array<int, mixed> Sync updates.
 	 */
 	public function get_updates_after_cursor( string $room, int $cursor ): array;