Skip to content

Commit

Permalink
Build/Test Tools: Use Git when fetching the WordPress Importer for us…
Browse files Browse the repository at this point in the history
…e in tests.

This switches to using Git in the local Docker environment install script to check out a copy of the WordPress Importer plugin for use in unit tests.

Previously, SVN was used and the commands were not correctly run within the Docker container. The container does not actually have SVN installed, and the script was only working when the machine running the command had SVN present.

Merges [51179] to the 4.8 branch.
Reviewed by swissspidy.

Props czapla, alexstine, jnylen0, francina, desrosj.
See #52909.
See #62280.

git-svn-id: https://develop.svn.wordpress.org/branches/4.8@59626 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
desrosj committed Jan 15, 2025
1 parent ad20852 commit 347f07b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
7 changes: 0 additions & 7 deletions .env
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,3 @@ LOCAL_WP_ENVIRONMENT_TYPE=local

# The URL to use when running e2e tests.
WP_BASE_URL=http://localhost:${LOCAL_PORT}

##
# The revision number of the WordPress Importer plugin to use when running unit tests.
#
# This should be an SVN revision number from the official plugin repository on wordpress.org.
##
WP_IMPORTER_REVISION=2387243
5 changes: 3 additions & 2 deletions tools/local-env/scripts/install.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ function wp_cli( cmd ) {
* Downloads the WordPress Importer plugin for use in tests.
*/
function install_wp_importer() {
const test_plugin_directory = 'tests/phpunit/data/plugins/wordpress-importer';
const testPluginDirectory = 'tests/phpunit/data/plugins/wordpress-importer';

execSync( `docker compose exec -T php rm -rf ${test_plugin_directory} && svn checkout -r ${process.env.WP_IMPORTER_REVISION} https://plugins.svn.wordpress.org/wordpress-importer/trunk/ ${test_plugin_directory}`, { stdio: 'inherit' } );
execSync( `docker compose exec -T php rm -rf ${testPluginDirectory}`, { stdio: 'inherit' } );
execSync( `docker compose exec -T php git clone https://github.com/WordPress/wordpress-importer.git ${testPluginDirectory} --depth=1 --branch 0.7`, { stdio: 'inherit' } );
}

0 comments on commit 347f07b

Please sign in to comment.