Connectors: Align setting name auto-generation with Gutenberg.

gziolo · claude · gziolo · commit 2736a09744e5 · 2026-03-27T17:06:13.000+01:00
Use string interpolation with str_replace wrapping the full
string, matching the Gutenberg implementation.

See #64957.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/src/wp-includes/class-wp-connector-registry.php b/src/wp-includes/class-wp-connector-registry.php
@@ -214,7 +214,7 @@ public function register( string $id, array $args ): ?array {
 				}
 				$connector['authentication']['setting_name'] = $args['authentication']['setting_name'];
 			} else {
-				$connector['authentication']['setting_name'] = 'connectors_' . str_replace( '-', '_', $args['type'] . '_' . $id ) . '_api_key';
+				$connector['authentication']['setting_name'] = str_replace( '-', '_', "connectors_{$connector['type']}_{$id}_api_key" );
 			}
 			if ( isset( $args['authentication']['constant_name'] ) ) {
 				if ( ! is_string( $args['authentication']['constant_name'] ) || '' === $args['authentication']['constant_name'] ) {

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ public function register( string $id, array $args ): ?array {`
`214`	`214`	`}`
`215`	`215`	`$connector['authentication']['setting_name'] = $args['authentication']['setting_name'];`
`216`	`216`	`} else {`
`217`		`- $connector['authentication']['setting_name'] = 'connectors_' . str_replace( '-', '_', $args['type'] . '_' . $id ) . '_api_key';`
	`217`	`+ $connector['authentication']['setting_name'] = str_replace( '-', '_', "connectors_{$connector['type']}_{$id}_api_key" );`
`218`	`218`	`}`
`219`	`219`	`if ( isset( $args['authentication']['constant_name'] ) ) {`
`220`	`220`	`if ( ! is_string( $args['authentication']['constant_name'] ) \|\| '' === $args['authentication']['constant_name'] ) {`