Change Site Health test from critical back to recommended

westonruter · felixarntz · westonruter · commit 02953c79d494 · 2025-01-17T10:40:58.000-08:00
Co-authored-by: felixarntz &lt;flixos90@git.wordpress.org&gt;
diff --git a/plugins/optimization-detective/site-health.php b/plugins/optimization-detective/site-health.php
@@ -110,7 +110,7 @@ function od_compose_site_health_result( $response ): array {
 	$error_description_html = '<p>' . esc_html__( 'You may have a plugin active or server configuration which restricts access to logged-in users. Unauthenticated access must be restored in order for Optimization Detective to work.', 'optimization-detective' ) . '</p>';
 
 	if ( is_wp_error( $response ) ) {
-		$result['status']      = 'critical';
+		$result['status']      = 'recommended';
 		$result['label']       = $error_label;
 		$result['description'] = $common_description_html . $error_description_html . '<p>' . wp_kses(
 			sprintf(
@@ -134,8 +134,12 @@ function od_compose_site_health_result( $response ): array {
 			count( $data['data']['params'] ) > 0
 		);
 		if ( ! $is_expected ) {
-			$result['status']      = 'critical';
-			$result['label']       = __( 'The Optimization Detective REST API endpoint is unavailable to logged-out users', 'optimization-detective' );
+			$result['status'] = 'recommended';
+			if ( 401 === $code ) {
+				$result['label'] = __( 'The Optimization Detective REST API endpoint is unavailable to logged-out users', 'optimization-detective' );
+			} else {
+				$result['label'] = $error_label;
+			}
 			$result['description'] = $common_description_html . $error_description_html . '<p>' . wp_kses(
 				sprintf(
 					/* translators: %d is the HTTP status code, %s is the status header description */
diff --git a/plugins/optimization-detective/tests/test-site-health.php b/plugins/optimization-detective/tests/test-site-health.php
@@ -105,13 +105,13 @@ public function data_provider_test_rest_api_availability(): array {
 			'unauthorized'    => array(
 				'mocked_response'      => $this->build_mock_response( ...self::UNAUTHORISED_MOCKED_RESPONSE_ARGS ),
 				'expected_option'      => '1',
-				'expected_status'      => 'critical',
+				'expected_status'      => 'recommended',
 				'expected_unavailable' => true,
 			),
 			'forbidden'       => array(
 				'mocked_response'      => $this->build_mock_response( ...self::FORBIDDEN_MOCKED_RESPONSE_ARGS ),
 				'expected_option'      => '1',
-				'expected_status'      => 'critical',
+				'expected_status'      => 'recommended',
 				'expected_unavailable' => true,
 			),
 			'nginx_forbidden' => array(
@@ -123,13 +123,13 @@ public function data_provider_test_rest_api_availability(): array {
 					'body'     => "<html>\n<head><title>403 Forbidden</title></head>\n<body>\n<center><h1>403 Forbidden</h1></center>\n<hr><center>nginx</center>\n</body>\n</html>",
 				),
 				'expected_option'      => '1',
-				'expected_status'      => 'critical',
+				'expected_status'      => 'recommended',
 				'expected_unavailable' => true,
 			),
 			'error'           => array(
 				'mocked_response'      => new WP_Error( 'bad', 'Something terrible has happened' ),
 				'expected_option'      => '1',
-				'expected_status'      => 'critical',
+				'expected_status'      => 'recommended',
 				'expected_unavailable' => true,
 			),
 		);
