Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataviews: Quick Edit controls labels are not accessible or empty #68746

Open
2 of 6 tasks
afercia opened this issue Jan 17, 2025 · 0 comments
Open
2 of 6 tasks

Dataviews: Quick Edit controls labels are not accessible or empty #68746

afercia opened this issue Jan 17, 2025 · 0 comments
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Fields /packages/fields [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jan 17, 2025

Description

1
In the data views quick edit, the controls to edit the edited object properties use an aria-label that completley mismatches the visible text. This pattern isn't accesisble and must be avoided. For example:

  • Vieibls text: Published
  • aria-label="Edit Status & Visibility"

or, another example:

  • Visible text: Closed
  • aria-label="Edit Discussion"

This pattern was already reported as not accessible almost 8 years ago in #470 and htere's no full solution yet. In the post summary panel, it as only been mitigated but still the visible text and the aria-label mismatch. See #63992
Buttons should be labeled to communicate what they do. For no reason a value or state should be used to bale interactive controls.

2
Multiple selection.
When more than one object is selected, the Quick edit panel shows a reduced set of properties that can be edited. Currently:

  • Author
  • Date
  • Discussion

Image

The Author ane Discussion buttons are empty. The Discussion button is not visible at all because, well, it's empty.
The Date button shows the current date / time.
Still, these buttons use aria-labels that completely mismach the visible (or missing) text:

  • aria-label="Edit Author"
  • aria-label="Edit Date"
  • aria-label="Edit Discussion"

These aria-labels also deviate from the pattern used in the Post summary where, at least, the aria-label is a combination of the action and value. Though slightly better, that pattern isn't accessible as well as reported on #63992 and originally on #470.

  • aria-label="Change author: admin"
  • aria-label="Change date: December 16, 2024 11:38 am UTC+0"
  • aria-label="Change discussion options"

it is worth reminding that the Classic admin 'Bulk edit' shows a 'No change' label for properties of multiple selected obects. Screenshot:

Image

Step-by-step reproduction instructions

  • Go to the WP admin > Gutenberg > Experiments and enable 'Data Views: add Quick Edit'.
  • Go to the Site editor > Pages and switch to the Table view for making testing easier.
  • Click the 'Details' icon button at the top of the page to open the Quick Edit panel.
  • Select one page.
  • Observe the visible text of all the buttons in the Quick Edit panel mismatch the buttons aria-label attributes.
  • Select more than one page.
  • Observe the Author button only shows an icon.
  • Observe the Discussion button is empty and not visible (unless focused).

Expected behaviour

  • The visible text to not mismatch the aria-label or the aria-label to be entirely removed and the buttons to use a meaningfultext.
  • The buttons to not be empty.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@afercia afercia added [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Fields /packages/fields [Type] Bug An existing feature does not function as intended labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Fields /packages/fields [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant