Dataviews: Quick Edit controls labels are not accessible or empty #68746
Labels
[Feature] DataViews
Work surrounding upgrading and evolving views in the site editor and beyond
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Package] Fields
/packages/fields
[Type] Bug
An existing feature does not function as intended
Description
1
In the data views quick edit, the controls to edit the edited object properties use an aria-label that completley mismatches the visible text. This pattern isn't accesisble and must be avoided. For example:
or, another example:
This pattern was already reported as not accessible almost 8 years ago in #470 and htere's no full solution yet. In the post summary panel, it as only been mitigated but still the visible text and the aria-label mismatch. See #63992
Buttons should be labeled to communicate what they do. For no reason a value or state should be used to bale interactive controls.
2
Multiple selection.
When more than one object is selected, the Quick edit panel shows a reduced set of properties that can be edited. Currently:
The Author ane Discussion buttons are empty. The Discussion button is not visible at all because, well, it's empty.
The Date button shows the current date / time.
Still, these buttons use aria-labels that completely mismach the visible (or missing) text:
These aria-labels also deviate from the pattern used in the Post summary where, at least, the aria-label is a combination of the action and value. Though slightly better, that pattern isn't accessible as well as reported on #63992 and originally on #470.
it is worth reminding that the Classic admin 'Bulk edit' shows a 'No change' label for properties of multiple selected obects. Screenshot:
Step-by-step reproduction instructions
Expected behaviour
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Please confirm which theme type you used for testing.
The text was updated successfully, but these errors were encountered: