Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Typography Dimensions Custom size behaviour is not working as expected. #68734

Open
3 of 6 tasks
viralsampat-multidots opened this issue Jan 17, 2025 · 4 comments · May be fixed by #68740
Open
3 of 6 tasks

Block Typography Dimensions Custom size behaviour is not working as expected. #68734

viralsampat-multidots opened this issue Jan 17, 2025 · 4 comments · May be fixed by #68740
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@viralsampat-multidots
Copy link
Contributor

Description

Hello Team,

I have worked on gutenberg blocks and found that block setting typography dimensions custom size is not working as expected. I have checked its with "Paragraph", "Pullquote", "Quote" blocks.

The issue is, when we change typography dimensions type from "Use size preset" to "Set Custom Size" for padding/margin both, And change it's type from "px" to any others, then it reset to "px" again. We have to select other option twicely to change its type based on requirement.

For better understanding, I have prepared its video.

Issue Video:

Screen.Recording.2025-01-17.at.12.29.23.PM.mp4

Step-by-step reproduction instructions

  • Select any block paragraph, pullquote, quote, etc.
  • Add dummy text
  • Go to block settings and change "Typography Dimensions" from "Use size preset" to "Set Custom Size"
  • Now, change its type from "px" to any other based on requirement
  • Now, change size using range control.

Screenshots, screen recording, code snippet

No response

Environment info

  • WordPress version: WordPress 6.7.1 running
  • Browser: Google Chrome, Version 131.0.6778.140 (Official Build) (arm64)
  • Device:** MacBook Air M1
  • OS: macOS 15.2 (24C101)
  • Gutenberg plugin: Version Version Version 20.0.0

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@viralsampat-multidots viralsampat-multidots added the [Type] Bug An existing feature does not function as intended label Jan 17, 2025
@yogeshbhutkar
Copy link
Contributor

Thanks for reporting! I'll be looking into the root cause for this.

@Mayank-Tripathi32
Copy link
Contributor

Mayank-Tripathi32 commented Jan 17, 2025

Hey, this could be related to #51616, I will test and add a solution

@yogeshbhutkar
Copy link
Contributor

yogeshbhutkar commented Jan 17, 2025

Seems like there already exists a PR that can fix this issue: #68212

@Mayank-Tripathi32
Copy link
Contributor

Seems like there already exists a PR that can fix this issue: #68212

It didn't completely resolve this issue, So I opened a separate PR to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants