Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Kindle Embed Showing Default Title #68714

Open
3 of 6 tasks
kartikmehta8 opened this issue Jan 16, 2025 · 4 comments · May be fixed by #68716
Open
3 of 6 tasks

Amazon Kindle Embed Showing Default Title #68714

kartikmehta8 opened this issue Jan 16, 2025 · 4 comments · May be fixed by #68716
Labels
[Block] Embed Affects the Embed Block [Type] Bug An existing feature does not function as intended

Comments

@kartikmehta8
Copy link

Description

The Amazon Kindle Embed block in the Gutenberg editor should display a default state (Amazon Kindle Embed - "Embed Amazon Kindle content.") when no URL is entered [Working correctly].
Image

However, upon embedding a URL, the block incorrectly reverts to displaying the default text instead of the Kindle one.
Image

Step-by-step reproduction instructions

  • Open a post/page in the WordPress Gutenberg editor.
  • Add a new block by clicking the "+" button.
  • Search for and insert the "Amazon Kindle Embed" block.
  • Observe the default text in the block:
    - Expected behavior: The block displays: Amazon Kindle Embed - "Embed Amazon Kindle content."
  • Enter a valid Amazon Kindle URL in the block's URL field and press Enter.
  • Expected behavior: The block displays: Amazon Kindle Embed - "Embed Amazon Kindle content." [SAME like other blocks]
  • Actual behavior: The block displays the default placeholder text (Add a block that displays content pulled from other sites, like Twitter or YouTube.) instead of rendering the embedded preview.

Screenshots, screen recording, code snippet

  • When no URL is added:
    Image
  • When URL is added:
    Image

Environment info

  • WordPress version: 6.8
  • Gutenberg version: 20.0.0
  • Active theme: Twenty Twenty Five

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@kartikmehta8 kartikmehta8 added the [Type] Bug An existing feature does not function as intended label Jan 16, 2025
@kartikmehta8
Copy link
Author

I would like to work on this issue!

@kartikmehta8 kartikmehta8 linked a pull request Jan 16, 2025 that will close this issue
@Mamaduka Mamaduka added the [Block] Embed Affects the Embed Block label Jan 16, 2025
@Mamaduka
Copy link
Member

@kartikmehta8, can you share a Kindle URL that can be used for testing?

@kartikmehta8
Copy link
Author

@Mamaduka I used this and found the issue.

@Mamaduka
Copy link
Member

I had trouble with that link, but the following worked in my tests - https://www.amazon.com/Eric-Discworld-Unseen-University-Collection-ebook/dp/B00GU32WNY/.

The provider name has changed from amazon-kindle to amazon on the backend. For additional context, it would be nice to locate where and why that change happened.

Screenshot

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants