Re-enable client-side media processing (#75848)

* Re-enable client-side media processing in the Gutenberg plugin

Remove the disabling shim that was added in #75756, re-enable the
cross-origin isolation e2e tests skipped in #75764, and add thorough
e2e tests for client-side media filename handling, scaled image
metadata, and thumbnail generation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Remove e2e test changes from this PR

The improved e2e tests for file naming belong in #75817 instead.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Clean up dead bootstrap filter refs in tests

The bootstrap override for client-side media processing was
removed, but tests still referenced it with remove_filter /
add_filter calls. Also replaces redundant "can be enabled"
test with a "can be disabled via filter" test.

---------

Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>

Author: 2 people

lib/compat/plugin/media.php

@@ -110,9 +110,6 @@ function gutenberg_is_experiment_enabled( $name ) {
 require __DIR__ . '/compat/wordpress-7.0/kses.php';
 require __DIR__ . '/compat/wordpress-7.0/media.php';
 
-// Gutenberg plugin compat: disable client-side media processing by default.
-require __DIR__ . '/compat/plugin/media.php';
-
 // Experimental features.
 require __DIR__ . '/experimental/block-editor-settings-mobile.php';
 require __DIR__ . '/experimental/blocks.php';

lib/load.php

@@ -96,11 +96,6 @@ function fail_if_died( $message ) {
 // Enable the widget block editor.
 tests_add_filter( 'gutenberg_use_widgets_block_editor', '__return_true' );
 
-// Enable client-side media processing for tests.
-// The Gutenberg plugin disables this by default (lib/compat/plugin/media.php),
-// but tests need the media functions to be loaded.
-tests_add_filter( 'wp_client_side_media_processing_enabled', '__return_true', 20 );
-
 // Start up the WP testing environment.
 require $_tests_dir . '/includes/bootstrap.php';
 

phpunit/bootstrap.php

@@ -202,31 +202,23 @@ public function test_gutenberg_override_media_templates(): void {
 	}
 
 	/**
-	 * Tests that client-side media processing is disabled by default in the Gutenberg plugin.
-	 *
-	 * The core compat layer defaults to true, but the Gutenberg plugin
-	 * adds a filter to disable it by default (lib/compat/plugin/media.php)
-	 * until known issues are resolved.
+	 * Tests that client-side media processing is enabled by default in the Gutenberg plugin.
 	 *
 	 * @covers ::gutenberg_is_client_side_media_processing_enabled
 	 */
-	public function test_client_side_media_processing_disabled_by_default_in_plugin() {
-		// Remove the test bootstrap override to check the plugin's actual default.
-		remove_filter( 'wp_client_side_media_processing_enabled', '__return_true', 20 );
-		$enabled = gutenberg_is_client_side_media_processing_enabled();
-		// Restore the test bootstrap override.
-		add_filter( 'wp_client_side_media_processing_enabled', '__return_true', 20 );
-
-		$this->assertFalse( $enabled );
+	public function test_client_side_media_processing_enabled_by_default_in_plugin() {
+		$this->assertTrue( gutenberg_is_client_side_media_processing_enabled() );
 	}
 
 	/**
-	 * Tests that client-side media processing can be enabled via filter.
+	 * Tests that client-side media processing can be disabled via filter.
 	 *
 	 * @covers ::gutenberg_is_client_side_media_processing_enabled
 	 */
-	public function test_client_side_media_processing_can_be_enabled() {
-		$this->assertTrue( gutenberg_is_client_side_media_processing_enabled() );
+	public function test_client_side_media_processing_can_be_disabled_via_filter() {
+		add_filter( 'wp_client_side_media_processing_enabled', '__return_false' );
+		$this->assertFalse( gutenberg_is_client_side_media_processing_enabled() );
+		remove_filter( 'wp_client_side_media_processing_enabled', '__return_false' );
 	}
 
 	/**
@@ -235,14 +227,11 @@ public function test_client_side_media_processing_can_be_enabled() {
 	 * @covers ::gutenberg_override_attachments_rest_controller
 	 */
 	public function test_compat_rest_controller_used_when_filter_disabled() {
-		// Remove the test bootstrap override so the disable filter takes effect.
-		remove_filter( 'wp_client_side_media_processing_enabled', '__return_true', 20 );
 		add_filter( 'wp_client_side_media_processing_enabled', '__return_false' );
 
 		$result = gutenberg_override_attachments_rest_controller( array(), 'attachment' );
 
 		remove_filter( 'wp_client_side_media_processing_enabled', '__return_false' );
-		add_filter( 'wp_client_side_media_processing_enabled', '__return_true', 20 );
 
 		$this->assertSame(
 			array( 'rest_controller_class' => 'Gutenberg_REST_Attachments_Controller_6_9' ),
@@ -256,7 +245,7 @@ public function test_compat_rest_controller_used_when_filter_disabled() {
 	 * @covers ::gutenberg_override_attachments_rest_controller
 	 */
 	public function test_compat_rest_controller_not_used_when_filter_enabled() {
-		// Feature is enabled via test bootstrap filter at priority 20.
+		// Feature is enabled by default (core compat layer).
 		$result = gutenberg_override_attachments_rest_controller( array(), 'attachment' );
 
 		$this->assertSame( array(), $result );